axis-c-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Mitchell (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AXIS2C-795) Possible seg fault looking for transport http prefix if specified URL omits :
Date Fri, 30 Nov 2007 21:03:43 GMT

    [ https://issues.apache.org/jira/browse/AXIS2C-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547289
] 

Bill Mitchell commented on AXIS2C-795:
--------------------------------------

I can see where error 4 is being recorded.  Unfortunately, this code is not getting returned
all the way to the client because of an issue I raised in AXIS2C-791.  After axis2_op_client_execute
returns the error, when the code in svc_client.c tries to reset the msg_ctx to null, axis2_op_client_add_msg_ctx()
replaces the error 4 with an uninformative error 2.  When I apply the change I described to
op_client.c to remove the non-null parameter validation of the message context, the error
4 is returned completely to the client application.  

Adding the log message is nice.  Thanks.  

> Possible seg fault looking for transport http prefix if specified URL omits : 
> ------------------------------------------------------------------------------
>
>                 Key: AXIS2C-795
>                 URL: https://issues.apache.org/jira/browse/AXIS2C-795
>             Project: Axis2-C
>          Issue Type: Bug
>          Components: core/clientapi
>    Affects Versions: 1.1.0
>         Environment: Windows XP, Visual Studio 2005
>            Reporter: Bill Mitchell
>            Assignee: Dinesh Premalal
>            Priority: Minor
>             Fix For: 1.2.0
>
>         Attachments: diff.txt
>
>
> In op_client.c, the function axis2_get_transport_from_url() is used to analyze the prefix
to the URL.  If the URL is malformed and does not contain a colon, the scan runs off the end
of the url string.
> The loop that reads:
>     start = url;
>     end = url;
>     while (end && (*end) != ':')
>         end++;
> should read:
>     start = url;
>     end = url;
>     while ((*end) && (*end) != ':')
>         end++;
> I'll admit to coming across this by inspection while tracking another problem.  I have
not actually forced the seg fault, as the loop will usually find a colon somewhere in memory
and return a very large transport string.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org


Mime
View raw message