Return-Path: Delivered-To: apmail-ws-axis-c-dev-archive@www.apache.org Received: (qmail 53875 invoked from network); 14 Jun 2007 02:54:16 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 14 Jun 2007 02:54:16 -0000 Received: (qmail 42517 invoked by uid 500); 14 Jun 2007 02:54:19 -0000 Delivered-To: apmail-ws-axis-c-dev-archive@ws.apache.org Received: (qmail 42500 invoked by uid 500); 14 Jun 2007 02:54:19 -0000 Mailing-List: contact axis-c-dev-help@ws.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: List-Id: "Apache AXIS C Developers List" Reply-To: "Apache AXIS C Developers List" Delivered-To: mailing list axis-c-dev@ws.apache.org Received: (qmail 42489 invoked by uid 99); 14 Jun 2007 02:54:19 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jun 2007 19:54:19 -0700 X-ASF-Spam-Status: No, hits=2.0 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of rajikacc@gmail.com designates 64.233.184.227 as permitted sender) Received: from [64.233.184.227] (HELO wr-out-0506.google.com) (64.233.184.227) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jun 2007 19:54:09 -0700 Received: by wr-out-0506.google.com with SMTP id i3so334605wra for ; Wed, 13 Jun 2007 19:53:48 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; b=nXgnklEyZfAatgIi6VTUOSOB2j/zqOSd/u0vHkuWaZxJ+yBhCOwrhcbNQOODuX8y5ElYKnofq4TTBCh5JVZQfNX6QVY8MlWaszyFDF3pVzogY67ZZbBj8iyq2kAMjVgRzZDarTnk9Vx+D1RihCtqrawglnJZujm2AozGp0mLeWE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; b=I851DzoBgrVj8qSN44iyA0wKnd35klV/04IkHhyg2Q+PBZUQb3sE5j3k7jqIc8PLmJH+R128ECur3gpxa3yRlsZAhP0ahdgYdhECuBLR+vvt6Psv/do5fISbocVU7P3GGqR6YDiJoaJFGMH8UVli5pMgokm1WFTA+JOmxqcBO/c= Received: by 10.90.50.1 with SMTP id x1mr1113669agx.1181789627779; Wed, 13 Jun 2007 19:53:47 -0700 (PDT) Received: by 10.90.51.10 with HTTP; Wed, 13 Jun 2007 19:53:47 -0700 (PDT) Message-ID: <696bc1d50706131953q66b7a37br27e70a3544d8c4b0@mail.gmail.com> Date: Thu, 14 Jun 2007 08:23:47 +0530 From: "Rajika Kumarasiri" To: "Apache AXIS C Developers List" Subject: Re: Mail Transport support for Axis2/C(GSOC 2007) In-Reply-To: <4670A0E8.2000805@wso2.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_16509_5704576.1181789627757" References: <696bc1d50706130337g14d5736cn8bc382f994aca408@mail.gmail.com> <4670A0E8.2000805@wso2.com> X-Virus-Checked: Checked by ClamAV on apache.org ------=_Part_16509_5704576.1181789627757 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline On 6/14/07, Samisa Abeysinghe wrote: > > > Rajika Kumarasiri wrote: > > hello everybody, > > I started to work on Mail Transport Sender part first implementing the > > following functions which implement the TransportSender interface. > > > > 1. axis2_status_t AXIS2_CALL > > axis2_mail_transport_sender_init( axis2_transport_sender_t > > *transport_sender, > > > > const_axutil_env_t *env > > > > axis2_conf_ctx_t *conf_ctx, > > > > axis2_transport_out_desc_t *out_desc); > > 2. axis2_status_t AXIS2_CALL > > axis2_mail_transport_sender_invoke( axis2_transport_sender_t > > *transport_sender, > > const > > axutil_env_t *env, > > > > axis2_msg_ctx_t *msg_ctx); > > > > 3. axis2_status_t AXIS2_CALL > > axis2_mail_transport_sender_clean_up( axis2_transport_sender_t > > *transport_sender, > > > > const axutil_env_t *env, > > > > axis2_msg_ctx_t *msg_ctx); > In line with what we already have with HTTP transport, I prefer the > prefix 'axis2_smtp_transport_' over 'axis2_mail_transport_', for the > function names. Well, Mail Transport itself is a combination of two protocols (at least) SMTP(sending Emails) and POP3(retrieving Emails). "sender" prefix implies that we use SMTP and in the mail transport receiver part is going to prefix with "receiver" prefix which implies that we use POP3 (or IMAP). One day we will need to extend the EMAIL Transport such that it support other open protocols such as IMAP. At that point there will be conflict in naming(as far as I understand) the function if we are going to prefix sender with "smtp". Your comments are most welcome. > 4. void AXIS2_CALL > > axis2_http_transport_sender_free( axis2_transport_sender_t > > *transport_sender, > > const > > axutil_env_t *env); Should this be axis2_smtp_transport_sender_free? Yes , it is. My mistake. Sorry. Regards, Rajika Samisa... > > -- > Samisa Abeysinghe : http://www.wso2.org/ (WSO2 Oxygen Tank - Web Services > Developers' Portal) > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org > For additional commands, e-mail: axis-c-dev-help@ws.apache.org > > -- http://rajikacc.blogspot.com/ ------=_Part_16509_5704576.1181789627757 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline

On 6/14/07, Samisa Abeysinghe <samisa@wso2.com> wrote:

Rajika Kumarasiri wrote:
> hello everybody,
> I started to work on Mail Transport Sender part first implementing the
> following functions which implement the TransportSender interface.
>
> 1. axis2_status_t  AXIS2_CALL
>     axis2_mail_transport_sender_init( axis2_transport_sender_t
> *transport_sender,
>
> const_axutil_env_t *env
>
> axis2_conf_ctx_t *conf_ctx,
>
> axis2_transport_out_desc_t *out_desc);
> 2. axis2_status_t AXIS2_CALL
>     axis2_mail_transport_sender_invoke( axis2_transport_sender_t
> *transport_sender,
>                                                                  const
> axutil_env_t *env,
>
> axis2_msg_ctx_t *msg_ctx);
>
> 3. axis2_status_t  AXIS2_CALL
>     axis2_mail_transport_sender_clean_up( axis2_transport_sender_t
> *transport_sender,
>
> const axutil_env_t *env,
>
> axis2_msg_ctx_t *msg_ctx);
In line with what we already have with HTTP transport, I prefer the
prefix 'axis2_smtp_transport_' over 'axis2_mail_transport_', for the
function names.

Well, Mail Transport itself is a combination of two  protocols (at least) SMTP(sending Emails) and POP3(retrieving Emails). "sender" prefix implies that we use SMTP and in the mail transport receiver part is going to prefix with "receiver" prefix  which implies  that we use  POP3 (or IMAP). One day we will need to extend the EMAIL Transport such that it support other open protocols such as IMAP.  At that point there will be conflict in naming(as far as I understand) the function if we are going to prefix sender with "smtp".

Your comments are most welcome.

> 4. void AXIS2_CALL
>     axis2_http_transport_sender_free( axis2_transport_sender_t
> *transport_sender,
>                                                              const
> axutil_env_t *env);



Should this be axis2_smtp_transport_sender_free?

Yes , it is. My mistake. Sorry.
  Regards,
  Rajika

Samisa...

--
Samisa Abeysinghe : http://www.wso2.org/ (WSO2 Oxygen Tank - Web Services Developers' Portal)


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org




--
http://rajikacc.blogspot.com/ ------=_Part_16509_5704576.1181789627757--