axis-c-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Samisa Abeysinghe (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (AXIS2C-269) Try to clean up axis2_stream
Date Wed, 28 Mar 2007 08:16:32 GMT

     [ https://issues.apache.org/jira/browse/AXIS2C-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Samisa Abeysinghe resolved AXIS2C-269.
--------------------------------------

    Resolution: Fixed

Added flush and close as well. Other issues were also resolved as per the previous comments

> Try to clean up axis2_stream
> ----------------------------
>
>                 Key: AXIS2C-269
>                 URL: https://issues.apache.org/jira/browse/AXIS2C-269
>             Project: Axis2-C
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: Current (Nightly)
>            Reporter: James Clark
>         Assigned To: Samisa Abeysinghe
>            Priority: Minor
>             Fix For: 1.0.0
>
>
> For doing encryption and signing right, it will be important to have a clean, minimal
stream interface.  axis2_stream is a bit crufty at the moment.
> Specifically, the get_type method is bogus: if you have an OO type (which stream should
be), then you shouldn't have a method returning a type-code for each implementation.  It only
seems to be used in axis2_http_transport_utils_on_data_request. I don't understand what that's
doing, but I'm fairly sure get_type is not the best way to it.
> I would also suggest having separate input and output streams (unless there are really
cases where you need to have a random access stream that can be both read and written).
> Having both get_char and read in an interface is a bad idea.  Have just read.  You can
implement get_char as a function on top of read.
> unget is  a bad idea on your fundamental stream type.  If you really need it, create
a lookahead_stream derived from stream that provides this additional operation and forwards
to an underlying regular stream.  Providing a peek method is better than unget (it's clear
what the semantics of multiple peeks are).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org


Mime
View raw message