axis-c-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Samisa Abeysinghe (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (AXIS2C-257) free methods should return void not axis2_status_t
Date Tue, 27 Mar 2007 10:36:32 GMT

     [ https://issues.apache.org/jira/browse/AXIS2C-257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Samisa Abeysinghe resolved AXIS2C-257.
--------------------------------------

    Resolution: Fixed

Changed free method to return void

> free methods should return void not axis2_status_t
> --------------------------------------------------
>
>                 Key: AXIS2C-257
>                 URL: https://issues.apache.org/jira/browse/AXIS2C-257
>             Project: Axis2-C
>          Issue Type: Improvement
>    Affects Versions: Current (Nightly)
>            Reporter: Samisa Abeysinghe
>         Assigned To: Samisa Abeysinghe
>             Fix For: 1.0.0
>
>
> Although the allocator free method returns void, you've made the free
> methods of objects return an axis2_status_t.  However, your code almost
> always seems to ignore the returned status.  Either 
> a) free methods should return a status and all callers should always
> check it and deal with,  or
> b) free methods should return void
> I would suggest (b).  There's nothing useful you can do with an error
> from a free method, and there's no need for the user supplied free
> function to return an error.  The situation where free might need to
> generate an error are the case where memory has got corrupted through
> programmer error, but a return code isn't the right way to deal wit this
> situation.
> (based on comments by James)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org


Mime
View raw message