Return-Path: Delivered-To: apmail-ws-axis-c-dev-archive@www.apache.org Received: (qmail 99109 invoked from network); 6 Dec 2006 06:42:43 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 6 Dec 2006 06:42:43 -0000 Received: (qmail 417 invoked by uid 500); 6 Dec 2006 06:42:51 -0000 Delivered-To: apmail-ws-axis-c-dev-archive@ws.apache.org Received: (qmail 260 invoked by uid 500); 6 Dec 2006 06:42:51 -0000 Mailing-List: contact axis-c-dev-help@ws.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: List-Id: "Apache AXIS C Developers List" Reply-To: "Apache AXIS C Developers List" Delivered-To: mailing list axis-c-dev@ws.apache.org Received: (qmail 249 invoked by uid 99); 6 Dec 2006 06:42:51 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Dec 2006 22:42:51 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Dec 2006 22:42:41 -0800 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 9E9317142EC for ; Tue, 5 Dec 2006 22:42:21 -0800 (PST) Message-ID: <7801209.1165387341631.JavaMail.jira@brutus> Date: Tue, 5 Dec 2006 22:42:21 -0800 (PST) From: "Samisa Abeysinghe (JIRA)" To: axis-c-dev@ws.apache.org Subject: [jira] Updated: (AXIS2C-397) Rampart Utils - Some Code Improvements In-Reply-To: <30822254.1162963490990.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ http://issues.apache.org/jira/browse/AXIS2C-397?page=all ] Samisa Abeysinghe updated AXIS2C-397: ------------------------------------- Fix Version/s: 0.96 > Rampart Utils - Some Code Improvements > -------------------------------------- > > Key: AXIS2C-397 > URL: http://issues.apache.org/jira/browse/AXIS2C-397 > Project: Axis2-C > Issue Type: Improvement > Components: rampart > Affects Versions: Current (Nightly) > Environment: All > Reporter: Nabeel Yoosuf > Assigned To: Malinda Kaushalye Kapuruge > Priority: Minor > Fix For: 0.96 > > > I had a quick glance at some of the files in rampart utils..Some suggestions > 1. In some functions the same value is recalculated several times which is not efficient. > E.g. > rampart_utils.c:rampart_generate_nonce(..) > OXS_BUFFER_GET_SIZE(buffer, env) > rampart_cryto_utils.c:rampart_crypto_sha1(..) > axis2_base64_decode_len(nonce) > 2. Memory leaks > E.g. > rampart_crypt_utils.c:45 - what is allocated is not freed > 3. I find many printf's - are these for debugging? the better way is to perform a runtime debugging. > Thanks > -Nabeel -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org For additional commands, e-mail: axis-c-dev-help@ws.apache.org