axis-c-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimuthu Chathuranga" <dimut...@gmail.com>
Subject Re: [axis2c]suggestion to add a function AXIOM_CHILDREN_ITERATOR_MOVE_FIRST
Date Sun, 13 Aug 2006 04:50:50 GMT
the patch is attached with this

On 8/13/06, Dimuthu Chathuranga <dimuthuc@gmail.com> wrote:
>
>  Hi,
> I could not find a function reset_iterator, I guess you mean just rename
> my patch from move_first to reset. so i added the patch adding doc comments
> and renaming the function.
>
> Dimuthu
>
>
>  On 8/12/06, Samisa Abeysinghe <samisa.abeysinghe@gmail.com> wrote:
> >
> > Dimuthu Chathuranga wrote:
> > >
> > > it is better we have a 'move_first' function in the
> > > axiom_children_iterator. this is required because the iterator is not
> > > resetting whenever we called AXIOM_ELEMENT_GET_CHILDREN to retrieve
> > > the children_iterator.
> > To me it looks as if you want to reset the iterator with move_first . If
> > that is the case, IMHO it is more appropriate to call this method
> > 'reset_iterator' rather than 'move_first'.
> > >
> > > this is essential for codegen tool. Here I'm attaching a patch adding
> > > this function.
> > In your patch, the function doc comment is missing the parameter
> > information and return value info. Please do note that we are in the
> > process of improving the doc comments in the code and our example to
> > follow is axis2_svc_client.h. Yes I agree that we are yet to update the
> > AXIOM headers, but we would do so soon. Hence appreciate if you could
> > follow the proper style for any  new stuff.
> >
> >
> > Thanks,
> > Samisa...
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
> > For additional commands, e-mail: axis-c-dev-help@ws.apache.org
> >
> >
>

Mime
View raw message