Return-Path: Delivered-To: apmail-ws-axis-c-dev-archive@www.apache.org Received: (qmail 30434 invoked from network); 10 May 2006 11:23:11 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 10 May 2006 11:23:11 -0000 Received: (qmail 4847 invoked by uid 500); 10 May 2006 11:23:06 -0000 Delivered-To: apmail-ws-axis-c-dev-archive@ws.apache.org Received: (qmail 4655 invoked by uid 500); 10 May 2006 11:23:05 -0000 Mailing-List: contact axis-c-dev-help@ws.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: List-Id: "Apache AXIS C Developers List" Reply-To: "Apache AXIS C Developers List" Delivered-To: mailing list axis-c-dev@ws.apache.org Received: (qmail 4578 invoked by uid 99); 10 May 2006 11:23:05 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 May 2006 04:23:05 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of jayawark@gmail.com designates 64.233.166.179 as permitted sender) Received: from [64.233.166.179] (HELO py-out-1112.google.com) (64.233.166.179) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 May 2006 04:23:03 -0700 Received: by py-out-1112.google.com with SMTP id i49so3037368pyi for ; Wed, 10 May 2006 04:22:42 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; b=t5RGnLbqlCoCWkXlEpVeNbZf12fScq8hHzIKLrFmGDc/0ARxBe9TQobIfK+vDsWTOIUF8b332ml2DJJJu7bmnJscfb0+1BKdkUTOft5vPDgm5ensOWOdRV7qX/XfJLP7U0OvPk8r3tm2I18wLW2c+EcMepbqg74Ry2+vyIUWBJE= Received: by 10.35.91.15 with SMTP id t15mr1104963pyl; Wed, 10 May 2006 04:22:42 -0700 (PDT) Received: by 10.35.22.5 with HTTP; Wed, 10 May 2006 04:22:42 -0700 (PDT) Message-ID: <5e8118f30605100422j6537afa9y52dde587e07dee30@mail.gmail.com> Date: Wed, 10 May 2006 17:22:42 +0600 From: "nandika jayawardana" To: "Apache AXIS C Developers List" Subject: Re: [jira] Updated: (AXIS2C-158) Add new reader/writer methods In-Reply-To: <22767054.1147251786105.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_31379_29505758.1147260162789" References: <23565431.1146825087461.JavaMail.jira@brutus> <22767054.1147251786105.JavaMail.jira@brutus> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N ------=_Part_31379_29505758.1147260162789 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Content-Disposition: inline patch applied. Thanks for the patch. nandika On 5/10/06, Nabeel Yoosuf (JIRA) wrote: > > [ http://issues.apache.org/jira/browse/AXIS2C-158?page=3Dall ] > > Nabeel Yoosuf updated AXIS2C-158: > --------------------------------- > > Attachment: patch.xml.parser > > This patch changes the signature of the following methods: > axis2_xml_writer_create_for_memory > axis2_xml_reader_create_for_memory (previously > axis2_xml_reader_create_for_buffer) > AXIS2_XML_WRITER_GET_XML > > axis2_xml_reader_create_for_memory is changed to > axis2_xml_reader_create_for_io > > Different parser types are defined in the axis2_xml_parser_type enum > > > Add new reader/writer methods > > ----------------------------- > > > > Key: AXIS2C-158 > > URL: http://issues.apache.org/jira/browse/AXIS2C-158 > > Project: Axis2-C > > Type: Task > > > Components: xml/parser > > Versions: 0.91 > > Environment: All > > Reporter: Nabeel Yoosuf > > Attachments: patch.xml.parser > > > > I copied the issue we discussed in the mail list so that we dont loose > track of it. > > Changes to be done to reader and writer are listed below. > > writer > > =3D=3D=3D=3D=3D=3D > > new attributes to impl struct: > > int type; > > xmlDocPtr *docp; > > Original: > > AXIS2_DECLARE(axis2_xml_writer_t *) > > axis2_xml_writer_create_for_memory(axis2_env_t **env, > > axis2_char_t *encoding, > > int is_prefix_default, > > int compression); > > Modified: > > AXIS2_DECLARE(axis2_xml_writer_t *) > > axis2_xml_writer_create_for_memory(axis2_env_t **env, > > axis2_char_t *encoding, > > int is_prefix_default, > > int compression, > > int type); > > Add: > > int axis2_xml_writer_get_type(struct axis2_xml_writer xml_writer, > axis2_env_t **env); > > Original: > > axis2_char_t* AXIS2_CALL > > axis2_libxml2_writer_wrapper_get_xml(axis2_xml_writer_t *writer, > > axis2_env_t **env); > > Modified: > > void* AXIS2_CALL > > axis2_libxml2_writer_wrapper_get_xml(axis2_xml_writer_t *writer, > > axis2_env_t **env); > > Reader > > =3D=3D=3D=3D=3D=3D > > Original: > > AXIS2_DECLARE(axis2_xml_reader_t *) > > axis2_xml_reader_create_for_buffer(axis2_env_t **env, > > const axis2_char_t *buffer, > > int size, > > const axis2_char_t *encoding); > > Modified: > > AXIS2_DECLARE(axis2_xml_reader_t *) > > axis2_xml_reader_create_for_buffer(axis2_env_t **env, > > void *container, > > int size, > > const axis2_char_t *encoding, > > int type); > > Minor Issue: method name should ideally be > axis2_xml_reader_create_for_memory. Since we already have a method with t= he > same name, we need to refactor that name first. > > -- > This message is automatically generated by JIRA. > - > If you think it was sent incorrectly contact one of the administrators: > http://issues.apache.org/jira/secure/Administrators.jspa > - > For more information on JIRA, see: > http://www.atlassian.com/software/jira > > ------=_Part_31379_29505758.1147260162789 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline patch applied.
Thanks for the patch.

nandika


On 5/10/06, Nabeel Yoosuf (JIRA) <jir= a@apache.org> wrote:
     [ http://issues.apache.org/jira/browse/AXIS2C-158?page= =3Dall ]

Nabeel Yoosuf updated AXIS2C-158:
------------------= ---------------

    Attachment: patch.xml.parser

This patch chan= ges the signature of the following methods:
axis2_xml_writer_create_for_= memory
axis2_xml_reader_create_for_memory (previously axis2_xml_reader_c= reate_for_buffer)
AXIS2_XML_WRITER_GET_XML

axis2_xml_reader_create_for_memory is c= hanged to axis2_xml_reader_create_for_io

Different parser types are = defined in the axis2_xml_parser_type enum

> Add new reader/writer= methods
> -----------------------------
>
>   &nb= sp;      Key: AXIS2C-158
>  &= nbsp;       URL: http://issues.apache.org/jira/browse/A= XIS2C-158
>      Project: Axis2-C
>         Type: Task

= >   Components: xml/parser
>     Ver= sions: 0.91
>  Environment: All
>   &n= bsp; Reporter: Nabeel Yoosuf
>  Attachments: patch.xml.pars= er
>
> I copied the issue we discussed in the mail list so that= we dont loose track of it.
> Changes to be done to reader and writer are listed below.
> = writer
> =3D=3D=3D=3D=3D=3D
> new attributes to impl struct:> int type;
> xmlDocPtr *docp;
> Original:
> AXIS2_DE= CLARE(axis2_xml_writer_t *)
> axis2_xml_writer_create_for_memory(axis2_env_t **env,
> = ;            &n= bsp;            = ;         axis2_char_t *encoding,
>       &n= bsp;            = ;            &n= bsp;  int is_prefix_default,
>       &nb= sp;            =             &nb= sp;  int compression);
> Modified:
> AXIS2_DECLARE(axis2_xml_writer_= t *)
> axis2_xml_writer_create_for_memory(axis2_env_t **env,
>&= nbsp;           &nbs= p;            &= nbsp;         axis2_char_t *encoding,
>       &n= bsp;            = ;            &n= bsp;  int is_prefix_default,
>       &nb= sp;            =             &nb= sp;  int compression,
>        &nb= sp;           int type);
> Add:
> int axis2_xml_writer_get_type(struct axis2_xml_= writer xml_writer, axis2_env_t **env);
> Original:
> axis2_char= _t* AXIS2_CALL
> axis2_libxml2_writer_wrapper_get_xml(axis2_xml_write= r_t *writer,
>           &= nbsp;           &nbs= p;             axis2_env_t **env);
> Modified:
> void* AXIS2_CALL
> axis= 2_libxml2_writer_wrapper_get_xml(axis2_xml_writer_t *writer,
> &= nbsp;           &nbs= p;            &= nbsp;          axis2_env_t **env);
> Reader
> =3D=3D=3D=3D=3D=3D
> Origi= nal:
> AXIS2_DECLARE(axis2_xml_reader_t *)
> axis2_xml_reader_c= reate_for_buffer(axis2_env_t **env,
>     &n= bsp;            = ;            &n= bsp;   const axis2_char_t *buffer,
>       &nbs= p;            &= nbsp;           &nbs= p; int size,
>          &n= bsp;            = ;           const axis2_char_t *encoding);
> Modified:
> AXIS2_DECLARE(axis2_xml_= reader_t *)
> axis2_xml_reader_create_for_buffer(axis2_env_t **env,>           &nb= sp;            =           void *container,
>         &n= bsp;            = ;            in= t size,
>          &n= bsp;            = ;           const axis2_char_t *encoding,
>       &n= bsp;          int type);<= br>> Minor Issue: method name should ideally be axis2_xml_reader_create_= for_memory. Since we already have a method with the same name, we need to r= efactor that name first.

--
This message is automatically generated by JIRA.
-
If y= ou think it was sent incorrectly contact one of the administrators:
&nbs= p;  http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/j= ira


------=_Part_31379_29505758.1147260162789--