patch applied.
Thanks for the patch.

nandika


On 5/10/06, Nabeel Yoosuf (JIRA) <jira@apache.org> wrote:
     [ http://issues.apache.org/jira/browse/AXIS2C-158?page=all ]

Nabeel Yoosuf updated AXIS2C-158:
---------------------------------

    Attachment: patch.xml.parser

This patch changes the signature of the following methods:
axis2_xml_writer_create_for_memory
axis2_xml_reader_create_for_memory (previously axis2_xml_reader_create_for_buffer)
AXIS2_XML_WRITER_GET_XML

axis2_xml_reader_create_for_memory is changed to axis2_xml_reader_create_for_io

Different parser types are defined in the axis2_xml_parser_type enum

> Add new reader/writer methods
> -----------------------------
>
>          Key: AXIS2C-158
>          URL: http://issues.apache.org/jira/browse/AXIS2C-158
>      Project: Axis2-C
>         Type: Task

>   Components: xml/parser
>     Versions: 0.91
>  Environment: All
>     Reporter: Nabeel Yoosuf
>  Attachments: patch.xml.parser
>
> I copied the issue we discussed in the mail list so that we dont loose track of it.
> Changes to be done to reader and writer are listed below.
> writer
> ======
> new attributes to impl struct:
> int type;
> xmlDocPtr *docp;
> Original:
> AXIS2_DECLARE(axis2_xml_writer_t *)
> axis2_xml_writer_create_for_memory(axis2_env_t **env,
>                                   axis2_char_t *encoding,
>                                   int is_prefix_default,
>                                   int compression);
> Modified:
> AXIS2_DECLARE(axis2_xml_writer_t *)
> axis2_xml_writer_create_for_memory(axis2_env_t **env,
>                                   axis2_char_t *encoding,
>                                   int is_prefix_default,
>                                   int compression,
>                    int type);
> Add:
> int axis2_xml_writer_get_type(struct axis2_xml_writer xml_writer, axis2_env_t **env);
> Original:
> axis2_char_t* AXIS2_CALL
> axis2_libxml2_writer_wrapper_get_xml(axis2_xml_writer_t *writer,
>                                     axis2_env_t **env);
> Modified:
> void* AXIS2_CALL
> axis2_libxml2_writer_wrapper_get_xml(axis2_xml_writer_t *writer,
>                                     axis2_env_t **env);
> Reader
> ======
> Original:
> AXIS2_DECLARE(axis2_xml_reader_t *)
> axis2_xml_reader_create_for_buffer(axis2_env_t **env,
>                                  const axis2_char_t *buffer,
>                                  int size,
>                                  const axis2_char_t *encoding);
> Modified:
> AXIS2_DECLARE(axis2_xml_reader_t *)
> axis2_xml_reader_create_for_buffer(axis2_env_t **env,
>                                  void *container,
>                                  int size,
>                                  const axis2_char_t *encoding,
>                  int type);
> Minor Issue: method name should ideally be axis2_xml_reader_create_for_memory. Since we already have a method with the same name, we need to refactor that name first.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira