axis-c-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Samisa Abeysinghe <samisa.abeysin...@gmail.com>
Subject Re: [Axis2][Fwd: svn commit: r409195 - in /webservices/axis2/trunk/c: include/crypt.h util/include/crypt.h util/src/minizip/archive_extract.c util/src/minizip/unzip.c]
Date Thu, 25 May 2006 04:06:39 GMT
Even within util, can we keep the header with the name "crypt.h"? As per 
our conventions, we got to have a prefix to prevent namespace conflicts

Samisa...

Sanjaya Ratnaweera wrote:

> This is a header file from minizip uncompression library.  Therefore I 
> think this header file should move to util/src/minizip directory.
>
> Thanks.
>
> Sanjaya
>
> Samisa Abeysinghe wrote:
>
>> -1 to add a header with name "crypt.h" to include.
>> This should have "axis2_" prefix.
>> Also the functions in crypt.h are defined in the header itself. 
>> Rather only the prototype should be there in the header and the 
>> implementation in a source file.
>> Also the functions names in this header too miss the axis2_ prefix.
>>
>> Please fix the above.
>>
>> Thanks,
>> Samisa...
>>
>> -------- Original Message --------
>> Subject:     svn commit: r409195 - in /web services/axis2/trunk/c: 
>> include/crypt.h util/include/crypt.h 
>> util/src/minizip/archive_extract.c util/src/minizip/unzip.c
>> Date:     Wed, 24 May 2006 15:55:11 -0000
>> From:     pini@apache.org
>> To:     axis2-cvs@ws.apache.org
>>
>>
>>
>> Author: pini
>> Date: Wed May 24 08:55:11 2006
>> New Revision: 409195
>>
>> URL: http://svn.apache.org/viewvc?rev=409195&view=rev
>> Log:
>> moved header file to correct location
>>
>> Added:
>>    webservices/axis2/trunk/c/util/include/crypt.h
>>      - copied unchanged from r409194, 
>> webservices/axis2/trunk/c/include/crypt.h
>> Removed:
>>    webservices/axis2/trunk/c/include/crypt.h
>> Modified:
>>    webservices/axis2/trunk/c/util/src/minizip/archive_extract.c
>>    webservices/axis2/trunk/c/util/src/minizip/unzip.c
>>
>> Modified: webservices/axis2/trunk/c/util/src/minizip/archive_extract.c
>> URL: 
>> http://svn.apache.org/viewvc/webservices/axis2/trunk/c/util/src/minizip/archive_extract.c?rev=409195&r1=409194&r2=409195&view=diff

>>
>> ============================================================================== 
>>
>> --- webservices/axis2/trunk/c/util/src/minizip/archive_extract.c 
>> (original)
>> +++ webservices/axis2/trunk/c/util/src/minizip/archive_extract.c Wed 
>> May 24 08:55:11 2006
>> @@ -4,6 +4,7 @@
>> #include <zlib.h>
>> #include <fcntl.h>
>> #include <unzip.h>
>> +#include <crypt.h>
>>
>> #define CASESENSITIVITY (0)
>> #define WRITEBUFFERSIZE (8192)
>>
>> Modified: webservices/axis2/trunk/c/util/src/minizip/unzip.c
>> URL: 
>> http://svn.apache.org/viewvc/webservices/axis2/trunk/c/util/src/minizip/unzip.c?rev=409195&r1=409194&r2=409195&view=diff

>>
>> ============================================================================== 
>>
>> --- webservices/axis2/trunk/c/util/src/minizip/unzip.c (original)
>> +++ webservices/axis2/trunk/c/util/src/minizip/unzip.c Wed May 24 
>> 08:55:11 2006
>> @@ -170,7 +170,7 @@
>>
>>
>> #ifndef NOUNCRYPT
>> -#include "crypt.h"
>> +#include <crypt.h>
>> #endif
>>
>> /* 
>> =========================================================================== 
>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
>> For additional commands, e-mail: axis-cvs-help@ws.apache.org
>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
>> For additional commands, e-mail: axis-c-dev-help@ws.apache.org
>>
>>
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org


Mime
View raw message