axis-c-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrian Dick (JIRA)" <axis-c-...@ws.apache.org>
Subject [jira] Reopened: (AXISCPP-919) Double delete in generated DestroyInstance()
Date Thu, 09 Feb 2006 13:12:58 GMT
     [ http://issues.apache.org/jira/browse/AXISCPP-919?page=all ]
     
Adrian Dick reopened AXISCPP-919:
---------------------------------


Just been doing some digging in this area and discoverd why exactly this double delete exists.

The wrong object is being cast to pWCH.   It should actually be inst->_object.

> Double delete in generated DestroyInstance()
> --------------------------------------------
>
>          Key: AXISCPP-919
>          URL: http://issues.apache.org/jira/browse/AXISCPP-919
>      Project: Axis-C++
>         Type: Bug
>     Versions: current (nightly)
>     Reporter: Henrik Nordberg
>     Assignee: Adrian Dick
>     Priority: Critical
>      Fix For: current (nightly)
>  Attachments: diff.txt
>
> The generated code for each web service has this function:
> STORAGE_CLASS_INFO 
> int DestroyInstance(BasicHandler *inst)
> {
> 	if (inst)
> 	{
> 		WrapperClassHandler* pWCH = reinterpret_cast<WrapperClassHandler*>(inst);
> 		pWCH->fini();
> 		delete pWCH;		
> 		delete inst;
> 		return AXIS_SUCCESS;
> 	}
> 	return AXIS_FAIL;
> }
> The same pointer (inst and pWCH) is deleted twice. If inst is really of type WrapperClassHandler*,
as suggested by the reinterpret_cast<>, then the
> delete inst;
> call should be removed.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message