axis-c-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Samisa Abeysinghe <samisa.abeysin...@gmail.com>
Subject Re: [AXIS2] using a macro for parameter checking
Date Fri, 04 Nov 2005 06:15:43 GMT
nandika jayawardana wrote:

> Hi all,
>
> I think we can use a macro for parameter validation in the code,
> currently for all in parameters to functions we use
>
> if(!param)
> {
>      (*env)->error->error_number = AXIS2_ERROR_INVALID_NULL_PARAMETER;
>     return NULL; /* or appropriate return type */
> }
>
> these lines are repeatedly used everywhere in the code , so if we can 
> define a macro to do the above stuff
> the code will look much cleaner ,

This macro should only be used for mandatory parameters.
Anyway I am not a big fan of Macros. While it makes code smaller, it 
makes code less readable.
However, as we make heavy use of macros for function pointers, it does 
not hert to use few more :)

Samisa...

>
> what do u think about this .....
>
> regards ..
> nandika
>
>
>
>
>


Mime
View raw message