Mailing-List: contact axis-c-dev-help@ws.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache AXIS C Developers List" <axis-c-dev@ws.apache.org>
Message-ID: <659823007.1129085465340.JavaMail.jira@ajax.apache.org>
Date: Wed, 12 Oct 2005 04:51:05 +0200 (CEST)
From: "nadir amra (JIRA)" <axis-c-dev@ws.apache.org>
To: axis-c-dev@ws.apache.org
Subject: [jira] Closed: (AXISCPP-847) Wrong definition of INVALID_SOCKET for
 non MS Windows platforms.
In-Reply-To: <2101824990.1128419027496.JavaMail.jira@ajax.apache.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

     [ http://issues.apache.org/jira/browse/AXISCPP-847?page=all ]
     
nadir amra closed AXISCPP-847:
------------------------------

    Fix Version: 1.6 Alpha
     Resolution: Fixed

In UNIX implementations, socket descriptor is integer.  So I made the following changes in HTTPChannel.hpp and HTTPSSLChannel.hpp:

const int          INVALID_SOCKET = -1;   

The above use to be unsigned with value of 0. 

#ifdef WIN32
  	     unsigned
#endif
  	     int m_Sock;                               // Socket descriptor


> Wrong definition of INVALID_SOCKET for non MS Windows platforms.
> ----------------------------------------------------------------
>
>          Key: AXISCPP-847
>          URL: http://issues.apache.org/jira/browse/AXISCPP-847
>      Project: Axis-C++
>         Type: Bug
>   Components: Transport (axis3)
>     Versions: 1.5 Final
>  Environment: i5/OS (OS/400 iSeries) and *nix (Linux and others)
>     Reporter: Ernst Mikkelsen
>     Assignee: nadir amra
>     Priority: Critical
>      Fix For: 1.6 Alpha

>
> In HTTPChannel.hpp and HTTPSSLChannel.hpp, INVALID_SOCKET is defined as 0 (zero). This causes a client using Axis C++ to fail consequently with a HTTPTransportException on the first connection attempt on the i5/OS, because 0 (zero) in fact is a valid socket descriptor on the i5/OS platform (as well as it is on other platforms such as Linux). This also means that real errors are not caught because -1 from the API is compared with to a 0 (zero).
> To my knowledge, all platforms defines socket() to return either -1 or ~0 depending on whether socket() is implemented with a signed or unsigned return value.
> My suggestion would be to change the following two files:
>   HTTPChannel.hpp    line 56 in Axis C++ 1.5 Final
>   HTTPSSLChannel.hpp line 58 in Axis C++ 1.5 Final
>   from: const unsigned int INVALID_SOCKET =  0;
>   to:   const unsigned int INVALID_SOCKET = ~0;  // for unsigned socket() implementations
>   or:   const          int INVALID_SOCKET = -1;  // for signed socket() implementations
> As a workaround for this issue, I've tried to allocate a dummy socket in my client program before calling any of the Axis C++ methods, causing Axis C++ to succeed on the first connection attempt.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira