axis-c-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dinesh Premalal <xydin...@gmail.com>
Subject Re: [Axis2] Guththila Pull Parser Internal States]
Date Thu, 20 Oct 2005 11:03:08 GMT
Hi,


> Cool, many thanks for the quick response.
> Can we please rename S_0,..., S_4 to some sensible names please.


+1 for renaming..

Those states are defined in states enumeration.
(guththila_xml_pull_parser.h)

e.g.
> S_0 with ERROR_STATE etc.
> Looking at the diagram, may I suggest few names:
> S_0 --> GUTHTHILA_ERROR_STATE
> S_1 --> GUTHTHILA_START_STATE
> S_2 --> GUTHTHILA_WITHIN_TAG_STATE
> S_3 --> GUTHTHILA_AFTER_START_TAG_STATE
> S_4 --> GUTHTHILA_AFTER_END_TAG_STATE
>
> These are based on my understanding, which is not very comprehensive ;).
> Please review and suggest better ones


The names that you propose are seems to be Ok ( names are reasonable for the
states.)

+1 for the new states

thanks,
Dinesh

Then I could update the code
> accordingly.
>
> Thanks,
> Samisa...
>
> >
> >
> > thanks,
> > Dinesh
> >
> >
> >
> > --
> > W.Dinesh Premalal
> > premalwd@cse.mrt.ac.lk <mailto:premalwd@cse.mrt.ac.lk>
> > http://www.cse.mrt.ac.lk/~premalwd/
> > <http://www.cse.mrt.ac.lk/%7Epremalwd/>
>
>
>


--
W.Dinesh Premalal
premalwd@cse.mrt.ac.lk
http://www.cse.mrt.ac.lk/~premalwd/
Mime
View raw message