axis-c-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dushshantha Chandradasa (JIRA)" <axis-c-...@ws.apache.org>
Subject [jira] Commented: (AXISCPP-722) Overloaded processException in AxisEngineException class
Date Fri, 01 Jul 2005 04:06:01 GMT
    [ http://issues.apache.org/jira/browse/AXISCPP-722?page=comments#action_12314848 ] 

Dushshantha Chandradasa commented on AXISCPP-722:
-------------------------------------------------

Samisa wrote:

Yes, you are correct. Looks like the "processException" is doing what the constructor should
be doing. All these "processException" methods are private to the class and only used internally
to set the class data members. 
We have 5 constructors and each has a corresponding "processException"
version which is called from within the constructor. What we should do is to identify the
useful constructors, move the logic from 'processException" to constructor and remove all
unwanted constructors and all "processException" methods.


> Overloaded processException in AxisEngineException class
> --------------------------------------------------------
>
>          Key: AXISCPP-722
>          URL: http://issues.apache.org/jira/browse/AXISCPP-722
>      Project: Axis-C++
>         Type: Bug
>   Components: Server - Engine
>     Versions: current (nightly)
>  Environment: All
>     Reporter: Dushshantha Chandradasa

>
> Samisa Abeysinghe <samisa.abeysinghe@gmail.com> wrote on 30/06/2005
> > 11:04:29:
> > 
> > > Hi All,
> > >     We have several overloaded forms of processException in 
> > > AxisEngineException class.
> > > 
> > >     I am sure that we are not using all of those. It is quite hard
> > to
> > > undestand and locate the problem locations when maintaining the 
> > > implementation. Shall we drop those that are not used from the list 
> > > below?
> > > 
> > >     void processException(const exception* e);
> > >     void processException(const exception* e, const int
> > iExceptionCode);
> > >     void processException (const exception* e, char* pcMessage);
> > >     void processException(const int iExceptionCode);
> > >     void processException(const int iExceptionCode, char*
> > pcMessage);
> > > 
> > >     BTW, some can be replaced with the copy constructor. I think we 
> > > can drop the top 3 and keep the bottom 2. Sometime it is better to 
> > > KISS ;-)
> > > 
> > > Thanks,
> > > Samisa...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message