Return-Path: Delivered-To: apmail-ws-axis-c-dev-archive@www.apache.org Received: (qmail 43886 invoked from network); 25 May 2005 11:15:56 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 25 May 2005 11:15:56 -0000 Received: (qmail 48520 invoked by uid 500); 25 May 2005 11:15:56 -0000 Delivered-To: apmail-ws-axis-c-dev-archive@ws.apache.org Received: (qmail 48401 invoked by uid 500); 25 May 2005 11:15:55 -0000 Mailing-List: contact axis-c-dev-help@ws.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: List-Id: "Apache AXIS C Developers List" Reply-To: "Apache AXIS C Developers List" Delivered-To: mailing list axis-c-dev@ws.apache.org Received: (qmail 48380 invoked by uid 99); 25 May 2005 11:15:55 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from ajax-1.apache.org (HELO ajax.apache.org) (192.87.106.226) by apache.org (qpsmtpd/0.28) with ESMTP; Wed, 25 May 2005 04:15:54 -0700 Received: from ajax.apache.org (ajax.apache.org [127.0.0.1]) by ajax.apache.org (Postfix) with ESMTP id BD8B3CB for ; Wed, 25 May 2005 13:15:51 +0200 (CEST) Message-ID: <398961282.1117019751743.JavaMail.jira@ajax.apache.org> Date: Wed, 25 May 2005 13:15:51 +0200 (CEST) From: "Samisa Abeysinghe (JIRA)" To: axis-c-dev@ws.apache.org Subject: [jira] Commented: (AXISCPP-659) Move connection opening out of flushOutput method In-Reply-To: <1561522159.1116999231437.JavaMail.jira@ajax.apache.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/AXISCPP-659?page=comments#action_66257 ] Samisa Abeysinghe commented on AXISCPP-659: ------------------------------------------- I think the best place where we could call Transport::openConnection is in ClientAxisEngine::invoke() method. I tried including it like the following inside invoke: if (AXIS_SUCCESS != (Status = m_pSZ->setOutputStream (m_pSoap))) break; m_pSoap->openConnection(); m_pSZ->markEndOfStream(); So before calling markEndOfStream whuch calls Transport::flushOutput(), I open the connection. flushOutput will only other about writing to the stream, and not open the connection. > Move connection opening out of flushOutput method > ------------------------------------------------- > > Key: AXISCPP-659 > URL: http://issues.apache.org/jira/browse/AXISCPP-659 > Project: Axis-C++ > Type: Improvement > Components: Transport (axis3) > Versions: 1.5 Final > Reporter: Samisa Abeysinghe > Assignee: Samisa Abeysinghe > Fix For: 1.6 Alpha > > Connection opening should not be the responsibility of the flushOutput method. Rather it has to be an independent act. > When connection opening is within the flushOutput, it becomes harder to debug. Hence it is ideal to move this to out of flushOutput. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira