Mailing-List: contact axis-c-dev-help@ws.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache AXIS C Developers List" <axis-c-dev@ws.apache.org>
Message-ID: <33226189.1097834151295.JavaMail.apache@nagoya>
Date: Fri, 15 Oct 2004 02:55:51 -0700 (PDT)
From: axis-c-dev@ws.apache.org
To: axis-c-dev@ws.apache.org
Subject: [jira] Closed: (AXISCPP-37) Apache Module: mod_axis2 causes crash
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Message:

   The following issue has been closed.

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/AXISCPP-37

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: AXISCPP-37
    Summary: Apache Module: mod_axis2 causes crash
       Type: Bug

     Status: Closed
 Resolution: FIXED

    Project: Axis-C++
 Components: 
             Transport (Server)
   Fix Fors:
             current (nightly)
   Versions:
             1.0 Final

   Assignee: 
   Reporter: Roland Kosovsky

    Created: Thu, 15 Jan 2004 4:08 PM
    Updated: Fri, 15 Oct 2004 2:54 AM
Environment: Operating System: Other
Platform: Other

Description:
"sstr->so.http.op_headercount" is not set to 0 in file "mod_axis2.c". During my
tests this caused a crash (in "mod_axis.c" it is zeroed).

mod_axis2.c, Ln 138:
static int mod_axis_method_handler (request_rec *req_rec)
...
    sstr = malloc(sizeof(Ax_soapstream));
    memset(sstr, 0, sizeof(Ax_soapstream)); // <<<<< insert this line


However a found an other bug:
 ...
 if(0 != process_request(sstr))
     {
         /*ap_rputs("SOAP Engine failed to response",req_rec);*/
         return OK;  // ###### sstr will never be freed!!!!!
     }
     if (sstr->so.http.op_headers)
         free(sstr->so.http.op_headers);
     free(sstr);
...


My suggestion is to create to object on stack so it will be deleted for free:
  Ax_soapstream obj;
  memset(&obj, 0, sizeof(obj));
  Ax_soapstream* sstr = &obj;  
  ...


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira