Return-Path: Delivered-To: apmail-ws-axis-c-dev-archive@www.apache.org Received: (qmail 34835 invoked from network); 14 Oct 2004 09:23:55 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 14 Oct 2004 09:23:55 -0000 Received: (qmail 72268 invoked by uid 500); 14 Oct 2004 09:23:54 -0000 Delivered-To: apmail-ws-axis-c-dev-archive@ws.apache.org Received: (qmail 72238 invoked by uid 500); 14 Oct 2004 09:23:53 -0000 Mailing-List: contact axis-c-dev-help@ws.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: List-Id: "Apache AXIS C Developers List" Reply-To: "Apache AXIS C Developers List" Delivered-To: mailing list axis-c-dev@ws.apache.org Received: (qmail 72223 invoked by uid 99); 14 Oct 2004 09:23:53 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [192.18.33.10] (HELO exchange.sun.com) (192.18.33.10) by apache.org (qpsmtpd/0.28) with SMTP; Thu, 14 Oct 2004 02:23:51 -0700 Received: (qmail 9704 invoked from network); 14 Oct 2004 09:25:51 -0000 Received: from localhost (HELO nagoya) (127.0.0.1) by nagoya.betaversion.org with SMTP; 14 Oct 2004 09:25:51 -0000 Message-ID: <1970131049.1097745951006.JavaMail.apache@nagoya> Date: Thu, 14 Oct 2004 02:25:51 -0700 (PDT) From: axis-c-dev@ws.apache.org To: axis-c-dev@ws.apache.org Subject: [jira] Created: (AXISCPP-202) enums cause name clashes Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Message: A new issue has been created in JIRA. --------------------------------------------------------------------- View the issue: http://issues.apache.org/jira/browse/AXISCPP-202 Here is an overview of the issue: --------------------------------------------------------------------- Key: AXISCPP-202 Summary: enums cause name clashes Type: Bug Status: Unassigned Priority: Major Project: Axis-C++ Components: Basic Architecture Versions: 1.3 Final Assignee: Reporter: Mark Whitlock Created: Thu, 14 Oct 2004 2:25 AM Updated: Thu, 14 Oct 2004 2:25 AM Description: > --- Valentin Kuznetsov wrote: > > > 2) Add namespace around all enums. I found that Axis > > conflicts with other software we use who also have > > enum with CRITICAL, INFO, WARN keywords. If we'll wrap > > those enum in axis into axis specific namespace all > > existing and potential future problems will go away. > > > > +1 > > Samisa... > Simply putting namespaces around these enums would break C applications, since C does not support namespaces. I agree this is the right solution for C++. For C, it would be good to prefix all enums with AXIS_. I don't think AXIS_SEVERITY_LEVEL needs to be externalised anyway, since it is only used by trace and AxisTrace.h is not external. There is also a problem with some externalised #defines like XML_Ch and SOAPACTIONHEADER which could also clash. So I propose move AXIS_SEVERITY_LEVEL to AxisTrace.h, for C++ put namespaces around all enums, for C prefix all enums with AXIS_, and for *both* C and C++ prefix all #defines with AXIS_. Unfortunately this will require applications changing, WSDL2WS changes and stubs being regenerated when users move to 1.3. Is this critical for 1.3 or should we just move AXIS_SEVERITY_LEVEL to AxisTrace.h in 1.3 and fix it all properly for 1.4? --------------------------------------------------------------------- JIRA INFORMATION: This message is automatically generated by JIRA. If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira