Mailing-List: contact user-help@avro.apache.org; run by ezmlm
Precedence: bulk
Reply-To: user@avro.apache.org
MIME-Version: 1.0
In-Reply-To: <F5036128B8264DE88593A15D26E0F146@gmail.com>
References: <1362021493836-4026430.post@n3.nabble.com>
	<CALEq1Z94g6S6upWTeSOXHuMczAL1MhMddgQ=KWD=AdhxuBrXAg@mail.gmail.com>
	<F5036128B8264DE88593A15D26E0F146@gmail.com>
Date: Thu, 28 Feb 2013 10:04:54 -0800
Message-ID: 
 <CALEq1Z9xy4sRondNx55EjsyGVOTEq-chGdSDGkwsAVR1M5UU+A@mail.gmail.com>
Subject: Re: Incorrect Json schema generated for @java_class
From: Doug Cutting <cutting@apache.org>
To: user@avro.apache.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

You could get the specific compiler to emit the desired type by
modifying the method SpecificCompiler#getStringType() to take the
Schema as a parameter and, if it has a java-class attribute, return
that.  Then things should work so long as you use ReflectDatumReader
and ReflectDatumWriter.  Would that suffice?

Doug

On Thu, Feb 28, 2013 at 9:25 AM, Alexandre Normand
<alexandre.normand@gmail.com> wrote:
> Hey Doug,
> I was also wondering about something related. In reflection, we can use t=
he
> java-class property to define the java class for stringable types. Could =
we
> find a way to bring some of this to the Specific generated classes so tha=
t a
> stringable type (I'm specifically thinking of BigDecimal and BigInteger)
> could be exposed as the java-class type instead of Strings? I started
> looking into this and there seem to be two possibilities, none of which I=
'm
> terribly excited about:
>
> 1. Use some reflection to invoke the string constructor for the
> java-class=E2=80=A6but that seems dirty as the Specific API probably shou=
ldn't do
> reflection, right?
> 2. Handle a very specific list of java-class types (such as BigDecimal an=
d
> BigInteger) and have code that deals specifically with these in
> Reader/Writer.
>
> Thoughts?
> --
> Alex
>
> On Thursday, February 28, 2013 at 9:19 AM, Doug Cutting wrote:
>
> Annotation names in IDL are copied directly to schema properties with
> the same names.
>
> The bug is in the IDL documentation, which uses the annotation
> @java_class in an example, which is meaningless. The Java
> implementation requires the "java-class" schema property, so the
> annotation used should be @java-class.
>
> I filed an issue in Jira for this.
>
> https://issues.apache.org/jira/browse/AVRO-1264
>
> Doug
>
> On Wed, Feb 27, 2013 at 7:18 PM, avronewbie <shilpav4@gmail.com> wrote:
>
> For the IDL field:
>
> @java_class("java.util.ArrayList") array<int> arrayOfInts;
>
> the JSON schema generated by the avro-maven-plugin is
>
> {\"name\":\"arrayOfInts\",\"type\":{\"type\":\"array\",\"items\":\"int\",=
\"java_class\":\"java.util.ArrayList\"}}
>
> Shouldn't it be generated in JSON as java-class (with hypen instead of
> underscore) instead of java_class? Because of this reading from avro file=
 is
> not working.
>
>
>
>
> --
> View this message in context:
> http://apache-avro.679487.n3.nabble.com/Incorrect-Json-schema-generated-f=
or-java-class-tp4026430.html
> Sent from the Avro - Users mailing list archive at Nabble.com.
>
>