Return-Path: X-Original-To: apmail-avro-user-archive@www.apache.org Delivered-To: apmail-avro-user-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C534AD2D2 for ; Tue, 11 Dec 2012 17:55:35 +0000 (UTC) Received: (qmail 88930 invoked by uid 500); 11 Dec 2012 17:55:35 -0000 Delivered-To: apmail-avro-user-archive@avro.apache.org Received: (qmail 88794 invoked by uid 500); 11 Dec 2012 17:55:34 -0000 Mailing-List: contact user-help@avro.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: user@avro.apache.org Delivered-To: mailing list user@avro.apache.org Received: (qmail 88770 invoked by uid 99); 11 Dec 2012 17:55:33 -0000 Received: from minotaur.apache.org (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Dec 2012 17:55:33 +0000 Received: from localhost (HELO mail-wi0-f179.google.com) (127.0.0.1) (smtp-auth username cutting, mechanism plain) by minotaur.apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Dec 2012 17:55:32 +0000 Received: by mail-wi0-f179.google.com with SMTP id o1so1859353wic.12 for ; Tue, 11 Dec 2012 09:55:30 -0800 (PST) MIME-Version: 1.0 Received: by 10.180.87.39 with SMTP id u7mr18153081wiz.6.1355248530741; Tue, 11 Dec 2012 09:55:30 -0800 (PST) Received: by 10.194.78.177 with HTTP; Tue, 11 Dec 2012 09:55:30 -0800 (PST) In-Reply-To: References: Date: Tue, 11 Dec 2012 09:55:30 -0800 Message-ID: Subject: Re: Grouping comparators - old vs new mapreduce APIs From: Doug Cutting To: user@avro.apache.org Content-Type: text/plain; charset=UTF-8 On Tue, Dec 11, 2012 at 7:11 AM, Dave Beech wrote: > What this means is, if you want to use a grouping comparator with the "new" > mapreduce API and Avro, you absolutely must provide an implementation of > RawComparator, or do the deserialization and delegating method call to > compare(x,y) yourself. This really isn't obvious and I haven't found it to > be documented anywhere. Sounds like we should at least add some documentation and probably also make this simpler. Perhaps we could provide a subclass of AvroKeyComparator that does the deserialization and delegates to compare(x,y)? Then folks can subclass this and override compare(x,y)? Doug