avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zezeng Wang (Jira)" <j...@apache.org>
Subject [jira] [Created] (AVRO-2790) Necessity of using Object as parameter of javaEscape method
Date Fri, 03 Apr 2020 03:02:00 GMT
Zezeng Wang created AVRO-2790:
---------------------------------

             Summary: Necessity of using Object as parameter of javaEscape method
                 Key: AVRO-2790
                 URL: https://issues.apache.org/jira/browse/AVRO-2790
             Project: Apache Avro
          Issue Type: Improvement
          Components: java
    Affects Versions: 1.9.2
            Reporter: Zezeng Wang
             Fix For: 1.10.0


The **[javaEscape|[https://github.com/apache/avro/blob/c81ea58c601a2f600d9d45cf50b9f6434b911d5a/lang/java/compiler/src/main/java/org/apache/avro/compiler/specific/SpecificCompiler.java#L976]]
method in *SpecificCompiler* is a utility used by templates. Escaping quotes and backslashes,
which means it's dealing with strings.
Utility for template use. Escapes quotes and backslashes.
And I checked the caller (*[enum.vm|[https://github.com/apache/avro/blob/c81ea58c601a2f600d9d45cf50b9f6434b911d5a/lang/java/compiler/src/main/velocity/org/apache/avro/compiler/specific/templates/java/classic/enum.vm#L31]],
[fixed.vm|[https://github.com/apache/avro/blob/c81ea58c601a2f600d9d45cf50b9f6434b911d5a/lang/java/compiler/src/main/velocity/org/apache/avro/compiler/specific/templates/java/classic/fixed.vm#L31]]*)
of javaEscape, all passed in as java.lang.String,
So I'm sure this should use java.lang.String as the input parameter and remove unnecessary
Object.toString operations.

 

Cheers,
Ze Zeng



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message