avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nandor Kollar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-2069) Use primitive fields in generated getters & setters in Java code
Date Fri, 01 Sep 2017 13:57:00 GMT

    [ https://issues.apache.org/jira/browse/AVRO-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150565#comment-16150565

Nandor Kollar commented on AVRO-2069:

[~dguitelson] looks like we still have test failures, TestSpecificRecordBuilder#testInterop
fails on my desktop with {{java.lang.AssertionError: Use assertEquals(expected, actual, delta)
to compare floating-point numbers}}. There are two asserts for float and double in this test,
could you please replace them to one with an additional delta parameter?

> Use primitive fields in generated getters & setters in Java code
> ----------------------------------------------------------------
>                 Key: AVRO-2069
>                 URL: https://issues.apache.org/jira/browse/AVRO-2069
>             Project: Avro
>          Issue Type: Improvement
>    Affects Versions: 1.8.2
>            Reporter: Daniil Gitelson
>            Assignee: Daniil Gitelson
> Currently, for primitive types (such as int, long, etc) generated getters and setters
return and accept java.lang.* boxed (while fields actually holds primitive values). This is
inefeccient and produces code boilerplate.
> Changed this behaviour in pull request: 
> https://github.com/apache/avro/pull/243

This message was sent by Atlassian JIRA

View raw message