avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-2069) Use primitive fields in generated getters & setters in Java code
Date Fri, 01 Sep 2017 13:13:01 GMT

    [ https://issues.apache.org/jira/browse/AVRO-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150481#comment-16150481
] 

Sean Busbey commented on AVRO-2069:
-----------------------------------

we'll need to flag this as an incompatible change, but I agree that it's a great improvement.

Normally users who rely on the specific compiler are performance sensitive. Do we have any
idea if the use of boxed object here was a discussed design decision? The only reason I can
think of to use them is it allows returning null, but that won't be the case if we're directly
referencing the primitives anyways.

> Use primitive fields in generated getters & setters in Java code
> ----------------------------------------------------------------
>
>                 Key: AVRO-2069
>                 URL: https://issues.apache.org/jira/browse/AVRO-2069
>             Project: Avro
>          Issue Type: Improvement
>    Affects Versions: 1.8.2
>            Reporter: Daniil Gitelson
>            Assignee: Daniil Gitelson
>
> Currently, for primitive types (such as int, long, etc) generated getters and setters
return and accept java.lang.* boxed (while fields actually holds primitive values). This is
inefeccient and produces code boilerplate.
> Changed this behaviour in pull request: 
> https://github.com/apache/avro/pull/243



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message