Mailing-List: contact dev-help@avro.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@avro.apache.org
Date: Mon, 7 Aug 2017 23:08:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@avro.apache.org
Message-ID: <JIRA.13092617.1501883559000.112569.1502147280198@Atlassian.JIRA>
In-Reply-To: <JIRA.13092617.1501883559000@Atlassian.JIRA>
References: <JIRA.13092617.1501883559000@Atlassian.JIRA> <JIRA.13092617.1501883559553@jira-lw-us.apache.org>
Subject: [jira] [Commented] (AVRO-2063) C: VERSION, SOVERSION not set
 correctly for shared library
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Mon, 07 Aug 2017 23:08:14 -0000


    [ https://issues.apache.org/jira/browse/AVRO-2063?page=3Dcom.atlassian.=
jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16117=
521#comment-16117521 ]=20

ASF GitHub Bot commented on AVRO-2063:
--------------------------------------

GitHub user edmonds opened a pull request:

    https://github.com/apache/avro/pull/239

    AVRO-2063. C: VERSION, SOVERSION not set correctly for shared library

    Prior to this commit the `VERSION` and `SOVERSION` properties were not =
being set correctly for the Avro C shared library. Previously, `VERSION` wa=
s unset, and `SOVERSION` was set to the full dotted version string (e.g. "2=
3.0.0"), which resulted in a `SONAME` of "libavro.so.23.0.0", which is inco=
rrect.
   =20
    This commit sets `SOVERSION` to the library's "current" version number =
(obtained by invoking `version.sh libcurrent`), and sets `VERSION` to the f=
ull dotted version string.
   =20
    This should result in a proper `libavro.so` =E2=86=92 `libavro.so.23` =
=E2=86=92 `libavro.so.23.0.0` symlink chain with a `SONAME` of "libavro.so.=
23".
   =20
    See Sune Vuorela's article on "CMake and library properties": http://pu=
sling.com/blog/?p=3D352.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/edmonds/avro edmonds/AVRO-2063

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/avro/pull/239.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #239
   =20
----
commit 5e852265ea7197efe809a8c37ec6a0c34811d3ba
Author: Robert Edmonds <edmonds@users.noreply.github.com>
Date:   2017-08-07T23:02:35Z

    AVRO-2063. C: VERSION, SOVERSION not set correctly for shared library
   =20
    Prior to this commit the VERSION and SOVERSION properties were not bein=
g
    set correctly for the Avro C shared library. Previously, VERSION was
    unset, and SOVERSION was set to the full dotted version string (e.g.
    "23.0.0"), which resulted in a SONAME of "libavro.so.23.0.0", which is
    incorrect.
   =20
    This commit sets SOVERSION to the library's "current" version number
    (obtained by invoking "version.sh libcurrent"), and sets VERSION to the
    full dotted version string.
   =20
    This should result in a proper libavro.so =E2=86=92 libavro.so.23 =E2=
=86=92
    libavro.so.23.0.0 symlink chain with a SONAME of "libavro.so.23".
   =20
    See Sune Vuorela's article on "CMake and library properties":
    http://pusling.com/blog/?p=3D352.

----


> C: VERSION, SOVERSION not set correctly for shared library
> ----------------------------------------------------------
>
>                 Key: AVRO-2063
>                 URL: https://issues.apache.org/jira/browse/AVRO-2063
>             Project: Avro
>          Issue Type: Bug
>          Components: c
>    Affects Versions: 1.8.2
>            Reporter: Robert Edmonds
>            Priority: Minor
>
> Hi,
> I'm attempting to package avro-c for Debian. While doing so, I noticed th=
at the libavro.so symlink that gets installed points directly to the libavr=
o.so.23.0.0 library file, without an intermediate "libavro.so.23" symlink, =
and that the SONAME embedded in the library file is set to "libavro.so.23.0=
.0", rather than "libavro.so.23", which is what I would expect for a librar=
y trying to follow the libtool-style current/revision/age scheme on Linux s=
ystems.
> It looks like the recommended way to get CMake to produce the typical sym=
link chain and SONAME is to set the VERSION property to "23.0.0" and the SO=
VERSION to 23 on the shared library target. See this article for details: h=
ttp://pusling.com/blog/?p=3D352.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)