avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nandor Kollar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-2072) ResolvingGrammarGenerator doesn't implement schema resolution correctly for unions
Date Wed, 30 Aug 2017 12:31:00 GMT

    [ https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147147#comment-16147147
] 

Nandor Kollar commented on AVRO-2072:
-------------------------------------

[~zolyfarkas] I don't see any test failure, guess you executed tests on your forked version
instead of Apache master. Looks like [intUnionIsNotConvertedToFloatUnion |https://github.com/zolyfarkas/avro/blob/trunk/lang/java/avro/src/test/java/org/apache/avro/TestReadingWritingDataInEvolvedSchemas.java#L158]
and [longUnionIsNotConvertedToFloatUnion|https://github.com/zolyfarkas/avro/blob/trunk/lang/java/avro/src/test/java/org/apache/avro/TestReadingWritingDataInEvolvedSchemas.java#L181]
are negative test: testing exactly what this Jira intends to fix right? Are these tests your
own test cases, or this was merged with a patch available Jira, which is not yet merged to
upstream trunk? As of the last test case, I'm not sure what is the problem.

> ResolvingGrammarGenerator doesn't implement schema resolution correctly for unions
> ----------------------------------------------------------------------------------
>
>                 Key: AVRO-2072
>                 URL: https://issues.apache.org/jira/browse/AVRO-2072
>             Project: Avro
>          Issue Type: Bug
>            Reporter: Nandor Kollar
>            Assignee: Nandor Kollar
>         Attachments: AVRO-2072.patch
>
>
> According to [specification|https://avro.apache.org/docs/current/spec.html#Schema+Resolution],
int and long is promotable to float, but when using SchemaValidator, a union with a single
int or long branch is not readable by an union with a float branch.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message