avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nandor Kollar (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (AVRO-2069) Use primitive fields in generated getters & setters in Java code
Date Wed, 30 Aug 2017 12:10:00 GMT

    [ https://issues.apache.org/jira/browse/AVRO-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147129#comment-16147129
] 

Nandor Kollar edited comment on AVRO-2069 at 8/30/17 12:09 PM:
---------------------------------------------------------------

[~dguitelson] looks like three tests fail in TestSpecificCompilerTool: testCompileSchemaTwoFiles,
testCompileSchemasUsingString and testCompileSchemaFileAndDirectory. You should change the
expected files (lang/java/tools/src/test/compiler/output/Player.java and lang/java/tools/src/test/compiler/output/Position.java),
the methods should return primitive types there according to your modification.


was (Author: nkollar):
[~dguitelson] looks like three test fails in TestSpecificCompilerTool: testCompileSchemaTwoFiles,
testCompileSchemasUsingString and testCompileSchemaFileAndDirectory. You should change the
expected files (lang/java/tools/src/test/compiler/output/Player.java and lang/java/tools/src/test/compiler/output/Position.java),
the methods should return primitive types there according to your modification.

> Use primitive fields in generated getters & setters in Java code
> ----------------------------------------------------------------
>
>                 Key: AVRO-2069
>                 URL: https://issues.apache.org/jira/browse/AVRO-2069
>             Project: Avro
>          Issue Type: Improvement
>    Affects Versions: 1.8.2
>            Reporter: Daniil Gitelson
>
> Currently, for primitive types (such as int, long, etc) generated getters and setters
return and accept java.lang.* boxed (while fields actually holds primitive values). This is
inefeccient and produces code boilerplate.
> Changed this behaviour in pull request: 
> https://github.com/apache/avro/pull/243



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message