avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1574) Suboptimal arraylist creation
Date Fri, 18 Aug 2017 14:58:02 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133070#comment-16133070
] 

ASF subversion and git services commented on AVRO-1574:
-------------------------------------------------------

Commit 09c997e206615c4b23ab9ae2ab5f6a3d793e9afb in avro's branch refs/heads/master from [~sekikn]
[ https://git-wip-us.apache.org/repos/asf?p=avro.git;h=09c997e ]

AVRO-1574: Create list for schema symbols with specified size.

Signed-off-by: Nandor Kollar <nkollar@cloudera.com>
Signed-off-by: Sean Busbey <busbey@apache.org>


> Suboptimal arraylist creation
> -----------------------------
>
>                 Key: AVRO-1574
>                 URL: https://issues.apache.org/jira/browse/AVRO-1574
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>    Affects Versions: 1.7.7
>            Reporter: Zoltan Farkas
>            Assignee: Kengo Seki
>            Priority: Trivial
>              Labels: beginner
>             Fix For: 1.7.8, 1.9.0, 1.8.3
>
>         Attachments: AVRO-1574.patch
>
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> in Schema.java:
> 1231         LockableArrayList<String> symbols = new LockableArrayList<String>();
>  
> 1232         for (JsonNode n : symbolsNode)
>  
> 1233           symbols.add(n.getTextValue());
> should be changed to:
> 1231         LockableArrayList<String> symbols = new LockableArrayList<String>(symbolsNode.size());
>  
> 1232         for (JsonNode n : symbolsNode)
>  
> 1233           symbols.add(n.getTextValue());
>  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message