avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1574) Suboptimal arraylist creation
Date Fri, 18 Aug 2017 14:21:00 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133016#comment-16133016
] 

Sean Busbey commented on AVRO-1574:
-----------------------------------

+1 pushing shortly.

> Suboptimal arraylist creation
> -----------------------------
>
>                 Key: AVRO-1574
>                 URL: https://issues.apache.org/jira/browse/AVRO-1574
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>    Affects Versions: 1.7.7
>            Reporter: Zoltan Farkas
>            Assignee: Kengo Seki
>            Priority: Trivial
>              Labels: beginner
>         Attachments: AVRO-1574.patch
>
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> in Schema.java:
> 1231         LockableArrayList<String> symbols = new LockableArrayList<String>();
>  
> 1232         for (JsonNode n : symbolsNode)
>  
> 1233           symbols.add(n.getTextValue());
> should be changed to:
> 1231         LockableArrayList<String> symbols = new LockableArrayList<String>(symbolsNode.size());
>  
> 1232         for (JsonNode n : symbolsNode)
>  
> 1233           symbols.add(n.getTextValue());
>  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message