avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "BELUGA BEHR (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-2056) DirectBinaryEncoder Creates Buffer For Each Call To writeDouble
Date Wed, 26 Jul 2017 15:30:01 GMT

    [ https://issues.apache.org/jira/browse/AVRO-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16101805#comment-16101805
] 

BELUGA BEHR commented on AVRO-2056:
-----------------------------------

[~gszadovszky] I'm sorry, but I do not understand your request to "add the Perf change." 
I did not change the Perf test to accomplish the testing other than un-comment the direct
binary encoder:

{code}
      Encoder e = encoder_factory.binaryEncoder(out, null);
//    Encoder e = encoder_factory.directBinaryEncoder(out, null);
{code}

> DirectBinaryEncoder Creates Buffer For Each Call To writeDouble
> ---------------------------------------------------------------
>
>                 Key: AVRO-2056
>                 URL: https://issues.apache.org/jira/browse/AVRO-2056
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>    Affects Versions: 1.7.7, 1.8.2
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Minor
>         Attachments: AVRO-2056.1.patch
>
>
> Each call to {{writeDouble}} creates a new buffer and promptly throws it away even though
the class has a re-usable buffer and is used in other methods such as {{writeFloat}}.  Remove
this extra buffer.
> {code:title=org.apache.avro.io.DirectBinaryEncoder}
>   // the buffer is used for writing floats, doubles, and large longs.
>   private final byte[] buf = new byte[12];
>   @Override
>   public void writeFloat(float f) throws IOException {
>     int len = BinaryData.encodeFloat(f, buf, 0);
>     out.write(buf, 0, len);
>   }
>   @Override
>   public void writeDouble(double d) throws IOException {
>     byte[] buf = new byte[8];
>     int len = BinaryData.encodeDouble(d, buf, 0);
>     out.write(buf, 0, len);
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message