Mailing-List: contact dev-help@avro.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@avro.apache.org
Date: Thu, 22 Jun 2017 17:02:00 +0000 (UTC)
From: "Doug Cutting (JIRA)" <jira@apache.org>
To: dev@avro.apache.org
Message-ID: <JIRA.13072650.1494984454000.83558.1498150920114@Atlassian.JIRA>
In-Reply-To: <JIRA.13072650.1494984454000@Atlassian.JIRA>
References: <JIRA.13072650.1494984454000@Atlassian.JIRA> <JIRA.13072650.1494984454188@jira-lw-us.apache.org>
Subject: [jira] [Updated] (AVRO-2035) enable validation of default values in
 schemas by default
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 22 Jun 2017 17:02:04 -0000


     [ https://issues.apache.org/jira/browse/AVRO-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting updated AVRO-2035:
-------------------------------
    Assignee: Doug Cutting
      Status: Patch Available  (was: Open)

> enable validation of default values in schemas by default
> ---------------------------------------------------------
>
>                 Key: AVRO-2035
>                 URL: https://issues.apache.org/jira/browse/AVRO-2035
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.8.1
>            Reporter: radai rosenblatt
>            Assignee: Doug Cutting
>             Fix For: 1.9.0
>
>         Attachments: AVRO-2035.patch
>
>
> suppose i have the following schema evolution:
> {code}
> {
>   "name": "Bob",
>   "type": "record",
>   "fields": [
>     {"name": "f1", "type": "int"}
>   ]
> }
> {code}
> and then:
> {code}
> {
>   "name": "Bob",
>   "type": "record",
>   "fields": [
>     {"name": "f1", "type": "int"},
>     {"name": "f2", "type": "boolean", "default": "true"}
>   ]
> }
> {code}
> the default value for "f2" is specified as the _STRING_ "true" (and not the literal boolean true). 
> if this default value is ever accessed (when reading a gen1-serialized object as a gen2) we get this:
> {code}
> org.apache.avro.AvroTypeException: Non-boolean default for boolean: "true"
> 	at org.apache.avro.io.parsing.ResolvingGrammarGenerator.encode(ResolvingGrammarGenerator.java:408)
> 	at org.apache.avro.io.parsing.ResolvingGrammarGenerator.getBinary(ResolvingGrammarGenerator.java:307)
> 	at org.apache.avro.io.parsing.ResolvingGrammarGenerator.resolveRecords(ResolvingGrammarGenerator.java:285)
> 	at org.apache.avro.io.parsing.ResolvingGrammarGenerator.generate(ResolvingGrammarGenerator.java:118)
> 	at org.apache.avro.io.parsing.ResolvingGrammarGenerator.generate(ResolvingGrammarGenerator.java:50)
> 	at org.apache.avro.io.ResolvingDecoder.resolve(ResolvingDecoder.java:85)
> 	at org.apache.avro.io.ResolvingDecoder.<init>(ResolvingDecoder.java:49)
> 	at org.apache.avro.io.DecoderFactory.resolvingDecoder(DecoderFactory.java:307)
> 	at org.apache.avro.generic.GenericDatumReader.getResolver(GenericDatumReader.java:127)
> 	at org.apache.avro.generic.GenericDatumReader.read(GenericDatumReader.java:142)
> {code}
> yet Schema.parse() passes for this


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)