avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From johnsgill3 <...@git.apache.org>
Subject [GitHub] avro pull request #218: Add valgrind to c tests
Date Sat, 15 Apr 2017 22:42:25 GMT
GitHub user johnsgill3 opened a pull request:

    https://github.com/apache/avro/pull/218

    Add valgrind to c tests

    With the work done for #217 in identifying memory leaks decided to make it a standard
part of the testing framework. This PR requires #217 otherwise `test_avro_schema` and `test_avro_values`
fail due to to `avro_schema_copy` calls.
    
    This PR includes
    - Adding valgrind tool to the docker container
    - Adding valgrind to `CMakeLists.txt` to optionally do valgrind testing if the tool is
found
    - Cleaning up existing tests that were failing due to not properly cleaning up memory
    - Lastly, as part of `./build.sh test` for `lang/c` do not remove the `build/c` directory.
The memcheck output is kept so that memory leak issues can be reviewed and addressed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/johnsgill3/avro add-valgrind-to-c-tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/avro/pull/218.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #218
    
----
commit a0c72d6370bf39aae5f97456c326a6f1feb2b48b
Author: John Gill <king2bgill@gmail.com>
Date:   2017-04-15T22:31:48Z

    Add valgrind tool to docker

commit f328adc82e753c753e96ec3d6f2c377cff68efef
Author: John Gill <king2bgill@gmail.com>
Date:   2017-04-15T22:32:20Z

    Don't clean after test. Allow review of memcheck files

commit 87e4f09d8c15c4917baf655dcb1614dc4dafd578
Author: John Gill <king2bgill@gmail.com>
Date:   2017-04-15T22:33:01Z

    Add valgrind to tests

commit e12ab455de950c333f13e5c8c5342f87e879ab4d
Author: John Gill <king2bgill@gmail.com>
Date:   2017-04-15T22:33:17Z

    Correct memory leaks in tests

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message