avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gabor Szadovszky (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1985) Unreleased resources
Date Sun, 22 Jan 2017 09:25:26 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833407#comment-15833407
] 

Gabor Szadovszky commented on AVRO-1985:
----------------------------------------

Thanks for reviewing, [~sacharya].
You're right, it won't be closed but it is intentional. {{RecordWriter}} is closeable and
it is up to the invoker to close it when it is required. I've added the closing of the newly
created output streams in case of any exception occurs during the creation of the record writer.

> Unreleased resources
> --------------------
>
>                 Key: AVRO-1985
>                 URL: https://issues.apache.org/jira/browse/AVRO-1985
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.8.1
>            Reporter: Gabor Szadovszky
>            Assignee: Gabor Szadovszky
>
> Static code analyzer tool found the following unreleased resources:
> - [Json.java:59|https://github.com/apache/avro/blob/master/lang/java/avro/src/main/java/org/apache/avro/data/Json.java#L59]
> - [DataFileWriter.java:216|https://github.com/apache/avro/blob/master/lang/java/avro/src/main/java/org/apache/avro/file/DataFileWriter.java#L205]
> - [SpecificCompiler.java:275|https://github.com/apache/avro/blob/master/lang/java/compiler/src/main/java/org/apache/avro/compiler/specific/SpecificCompiler.java#L275]
> - [AvroKeyOutputFormat.java:107|https://github.com/apache/avro/blob/master/lang/java/mapred/src/main/java/org/apache/avro/mapreduce/AvroKeyOutputFormat.java#L107]
> - [AvroKeyValueOutputFormat.java:63|https://github.com/apache/avro/blob/master/lang/java/mapred/src/main/java/org/apache/avro/mapreduce/AvroKeyValueOutputFormat.java#L63]
> - [IdlTool.java:62|https://github.com/apache/avro/blob/master/lang/java/tools/src/main/java/org/apache/avro/tool/IdlTool.java#L62]
> - [Main.java:92|https://github.com/apache/avro/blob/master/lang/java/tools/src/main/java/org/apache/avro/tool/Main.java#L92]
> - [Main.java:94|https://github.com/apache/avro/blob/master/lang/java/tools/src/main/java/org/apache/avro/tool/Main.java#L94]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message