avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suraj Acharya (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1972) Typo in method name
Date Sun, 22 Jan 2017 04:16:26 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833280#comment-15833280

Suraj Acharya commented on AVRO-1972:

+1 on the patch and I agree with [~gszadovszky]'s suggestion of moving it to 1.9.0.

> Typo in method name
> -------------------
>                 Key: AVRO-1972
>                 URL: https://issues.apache.org/jira/browse/AVRO-1972
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.8.1
>            Reporter: Francesco Versaci
>            Priority: Minor
>              Labels: typo
>             Fix For: 1.9.0
> There's a method of SpecificRecordBase.java which has a typo in the method name, i.e.,
`getConverion(String fieldName)` instead of `getConversion(String fieldName)`. 
> gszadovszky suggests two options, detailed below:
> ---
> This method is part of the public API and has already been released (1.8.1). We would
not like to break the code of any consumer in case of doing a minor upgrade therefore, I would
suggest deprecating the method with the typo and create a new one with the correct naming.
(Later on we will be able to remove the deprecated method.) Another idea is to keep the fix
as is but only include in the next major release.
> ---

This message was sent by Atlassian JIRA

View raw message