avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1972) Typo in method name
Date Fri, 27 Jan 2017 17:06:24 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843129#comment-15843129

Sean Busbey commented on AVRO-1972:

+1 for 1.9.0. I'll push this to master as soon as there's a 1.8.z patch available on AVRO-1987
to take care of the deprecation in 1.8 part.

> Typo in method name
> -------------------
>                 Key: AVRO-1972
>                 URL: https://issues.apache.org/jira/browse/AVRO-1972
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.8.1
>            Reporter: Francesco Versaci
>            Assignee: Francesco Versaci
>            Priority: Minor
>              Labels: typo
>             Fix For: 1.9.0
> There's a method of SpecificRecordBase.java which has a typo in the method name, i.e.,
`getConverion(String fieldName)` instead of `getConversion(String fieldName)`. 
> gszadovszky suggests two options, detailed below:
> ---
> This method is part of the public API and has already been released (1.8.1). We would
not like to break the code of any consumer in case of doing a minor upgrade therefore, I would
suggest deprecating the method with the typo and create a new one with the correct naming.
(Later on we will be able to remove the deprecated method.) Another idea is to keep the fix
as is but only include in the next major release.
> ---

This message was sent by Atlassian JIRA

View raw message