avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben McCann <bmcc...@linkedin.com.INVALID>
Subject Re: Fix for build failure
Date Wed, 25 Jan 2017 18:24:18 GMT
Great, thanks!!

If you have a chance there's one other PR I'd like to get into the 1.7
branch as well: https://github.com/apache/avro/pull/188

Thanks again Suraj. I really appreciate the help


On Wed, Jan 25, 2017 at 7:30 AM, suraj acharya <suraj.spa@gmail.com> wrote:

> I have reviewed the changes and it looks good to me.
>
> I have also created a JIRA so that it is tracked better :
> https://issues.apache.org/jira/browse/AVRO-1988
>
> Ill now try to get it in the 1.7 branch soon.
>
> -Suraj Acharya
>
> On Tue, Jan 24, 2017 at 2:40 PM, Ben McCann <bmccann@linkedin.com.invalid>
> wrote:
>
> > Thank you!
> >
> > On Tue, Jan 24, 2017 at 11:52 AM, suraj acharya <suraj.spa@gmail.com>
> > wrote:
> >
> > > Hey Ben,
> > > Thanks a lot for this request.
> > > Ill look at it this week. And find someone to commit it by Monday of
> next
> > > week.
> > >
> > >
> > >
> > > -Suraj Acharya
> > >
> > > On Tue, Jan 24, 2017 at 12:50 PM, Ben McCann
> > <bmccann@linkedin.com.invalid
> > > >
> > > wrote:
> > >
> > > > Would someone be able to look at this PR? The tests are currently
> > broken
> > > > without it
> > > >
> > > > https://github.com/apache/avro/pull/139
> > > >
> > > > Thanks,
> > > > Ben
> > > >
> > > >
> > > > On Sat, Jan 21, 2017 at 9:50 PM, Ben McCann <bmccann@linkedin.com>
> > > wrote:
> > > >
> > > > > Hi,
> > > > >
> > > > > I wanted to check and see if it'd be possible to get this PR merged
> > to
> > > > fix
> > > > > the currently broken tests.
> > > > >
> > > > > Thanks,
> > > > > Ben
> > > > >
> > > > > On Jan 17, 2017 1:09 PM, "Ben McCann" <bmccann@linkedin.com>
> wrote:
> > > > >
> > > > >> The tests on the 1.7 branch are currently broken due to a
> partially
> > > > >> applied commit. Would you be able to merge the following PR?
I've
> > > > confirmed
> > > > >> it fixes the issue by applying the remainder of the commit.
> > > > >>
> > > > >> https://github.com/apache/avro/pull/139
> > > > >>
> > > > >> Thanks,
> > > > >> Ben
> > > > >>
> > > > >>
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message