Mailing-List: contact dev-help@avro.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@avro.apache.org
Date: Wed, 30 Nov 2016 21:19:58 +0000 (UTC)
From: "Sean Timm (JIRA)" <jira@apache.org>
To: dev@avro.apache.org
Message-ID: <JIRA.13019955.1478813774000.405607.1480540798366@Atlassian.JIRA>
In-Reply-To: <JIRA.13019955.1478813774000@Atlassian.JIRA>
References: <JIRA.13019955.1478813774000@Atlassian.JIRA> <JIRA.13019955.1478813774481@arcas>
Subject: [jira] [Commented] (AVRO-1957) TimeConversions do not implement
 getRecommendedSchema()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 30 Nov 2016 21:20:00 -0000


    [ https://issues.apache.org/jira/browse/AVRO-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709801#comment-15709801 ] 

Sean Timm commented on AVRO-1957:
---------------------------------

If possible, it would be nice to get this in to 1.8.2. It is a fairly simple fix with PR and unit test.

> TimeConversions do not implement getRecommendedSchema()
> -------------------------------------------------------
>
>                 Key: AVRO-1957
>                 URL: https://issues.apache.org/jira/browse/AVRO-1957
>             Project: Avro
>          Issue Type: Bug
>    Affects Versions: 1.8.1
>            Reporter: Sean Timm
>
> org.apache.avro.data.TimeConversions.TimestampConversion and other date and time conversions do not implement getRecommendedSchema(). When trying to dynamically generate an Avro schema from a pojo that contains a DateTime object using ReflectData, I get an unsupported operation exception.
> I think the implementation should be as simple as
> {code}
> @Override
> public Schema getRecommendedSchema() {
>       return LogicalTypes.timestampMillis().addToSchema(Schema.create(Schema.Type.LONG));
> }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)