avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sanjosh <...@git.apache.org>
Subject [GitHub] avro pull request #157: AVRO-1542 replacing auto_ptr by unique_ptr & std::mo...
Date Tue, 15 Nov 2016 16:27:02 GMT
GitHub user sanjosh opened a pull request:

    https://github.com/apache/avro/pull/157

    AVRO-1542 replacing auto_ptr by unique_ptr & std::move

    
    Please verify 
    1) addition of flags to CMakeLists.txt and 
    2) one case where auto_ptr was being passed by reference but is now changed to pass unique_ptr
by value in lang/c++/impl/FileStream.cc  : 193
    
    all tests passed in my local build

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sanjosh/avro master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/avro/pull/157.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #157
    
----
commit b26e3431bcbde97470d38bdb0e5470b0f1a60086
Author: Sandeep Joshi <sanjos100@gmail.com>
Date:   2016-09-20T07:30:27Z

    AVRO-1542 replacing auto_ptr by unique_ptr & std::move

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message