avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Timm (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1957) TimeConversions do not implement getRecommendedSchema()
Date Wed, 30 Nov 2016 21:19:58 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709801#comment-15709801
] 

Sean Timm commented on AVRO-1957:
---------------------------------

If possible, it would be nice to get this in to 1.8.2. It is a fairly simple fix with PR and
unit test.

> TimeConversions do not implement getRecommendedSchema()
> -------------------------------------------------------
>
>                 Key: AVRO-1957
>                 URL: https://issues.apache.org/jira/browse/AVRO-1957
>             Project: Avro
>          Issue Type: Bug
>    Affects Versions: 1.8.1
>            Reporter: Sean Timm
>
> org.apache.avro.data.TimeConversions.TimestampConversion and other date and time conversions
do not implement getRecommendedSchema(). When trying to dynamically generate an Avro schema
from a pojo that contains a DateTime object using ReflectData, I get an unsupported operation
exception.
> I think the implementation should be as simple as
> {code}
> @Override
> public Schema getRecommendedSchema() {
>       return LogicalTypes.timestampMillis().addToSchema(Schema.create(Schema.Type.LONG));
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message