avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1887) set up precommit checks via Apache Yetus
Date Tue, 01 Nov 2016 17:50:58 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15626140#comment-15626140

Sean Busbey commented on AVRO-1887:

looks good. I'll play with this a bit before committing.

One small change, could you locate this in {{share/pre_commit}} instead of the top-level {{pre_commit}}?

That will put it near the other help-run-the-project stuff we have for e.g. Docker and git.

Have you gotten to try out using our Dockerfile to ensure the yetus run has all of our needed

> set up precommit checks via Apache Yetus
> ----------------------------------------
>                 Key: AVRO-1887
>                 URL: https://issues.apache.org/jira/browse/AVRO-1887
>             Project: Avro
>          Issue Type: Task
>          Components: build, community
>            Reporter: Sean Busbey
>            Assignee: Suraj Acharya
>            Priority: Blocker
>         Attachments: AVRO-1887-0.patch, AVRO-1887-1.patch
> The lack of automated checks for things like doing a full build is negatively impacting
my ability to do timely reviews. We should leverage the work done by other communities and
get precommit checks going with Apache Yetus ([ref Apache Yetus Precommit|http://yetus.apache.org/documentation/0.3.0/precommit-basic/])
> Yetus has built in support for using Docker as a containerized build environment ([ref
docs|https://yetus.apache.org/documentation/0.3.0/precommit-advanced/#Docker_Support]), but
I don't know if we can use the one we have directly or if we'll need to do some refactoring.
> Implementing this will ultimately require a committer (so that they can make changes
to builds.apache.org), but a non-cmmitter can get the bulk of the work done by managing to
do local yetus checks with the docker feature active.

This message was sent by Atlassian JIRA

View raw message