Mailing-List: contact dev-help@avro.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@avro.apache.org
Date: Tue, 11 Oct 2016 16:24:20 +0000 (UTC)
From: "Ryan Blue (JIRA)" <jira@apache.org>
To: dev@avro.apache.org
Message-ID: <JIRA.12755408.1415983126000.794657.1476203060555@Atlassian.JIRA>
In-Reply-To: <JIRA.12755408.1415983126000@Atlassian.JIRA>
References: <JIRA.12755408.1415983126000@Atlassian.JIRA> <JIRA.12755408.1415983126849@arcas>
Subject: [jira] [Commented] (AVRO-1605) Remove Jackson classes from public
 API
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 11 Oct 2016 16:24:22 -0000


    [ https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15565892#comment-15565892 ] 

Ryan Blue commented on AVRO-1605:
---------------------------------

Because I don't think accessors are a good practice, I think that we should not add them unless there is a compelling reason and for those we do add we should have a plan for removing them.

The current patch adds accessors where I don't think they are necessary. Getting the default value from a field should simply return the default as an Avro object. I don't think there's a performance penalty for that change, but we have benchmarks if we need to make sure that's the case. Another example is Accessor.parseJson. It's only used once and could easily be replaced with a new method: Schema.parseDefaultValue(String, Schema). I think the next steps are to try to remove as many as possible in this patch and have a good reason for the ones that remain.

Does that sound reasonable?

> Remove Jackson classes from public API
> --------------------------------------
>
>                 Key: AVRO-1605
>                 URL: https://issues.apache.org/jira/browse/AVRO-1605
>             Project: Avro
>          Issue Type: Sub-task
>          Components: java
>    Affects Versions: 1.7.8
>            Reporter: Tom White
>            Assignee: Gabor Szadovszky
>             Fix For: 1.9.0
>
>


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)