avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Blue (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1605) Remove Jackson classes from public API
Date Tue, 11 Oct 2016 16:24:20 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15565892#comment-15565892
] 

Ryan Blue commented on AVRO-1605:
---------------------------------

Because I don't think accessors are a good practice, I think that we should not add them unless
there is a compelling reason and for those we do add we should have a plan for removing them.

The current patch adds accessors where I don't think they are necessary. Getting the default
value from a field should simply return the default as an Avro object. I don't think there's
a performance penalty for that change, but we have benchmarks if we need to make sure that's
the case. Another example is Accessor.parseJson. It's only used once and could easily be replaced
with a new method: Schema.parseDefaultValue(String, Schema). I think the next steps are to
try to remove as many as possible in this patch and have a good reason for the ones that remain.

Does that sound reasonable?

> Remove Jackson classes from public API
> --------------------------------------
>
>                 Key: AVRO-1605
>                 URL: https://issues.apache.org/jira/browse/AVRO-1605
>             Project: Avro
>          Issue Type: Sub-task
>          Components: java
>    Affects Versions: 1.7.8
>            Reporter: Tom White
>            Assignee: Gabor Szadovszky
>             Fix For: 1.9.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message