avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Simon24601 <...@git.apache.org>
Subject [GitHub] avro pull request #131: Avro1363 C# union schema can now contain multiple en...
Date Mon, 26 Sep 2016 23:28:15 GMT
GitHub user Simon24601 opened a pull request:

    https://github.com/apache/avro/pull/131

    Avro1363  C# union schema can now contain multiple entries with the same name and different
namespace

    When processing a UnionSchema, we store a list of all the names that have already been
processed. In Java, the fully-resolved names are used (including namespaces), while in C#
only the simple name was used. This means that a UnionSchema cannot contain multiple entries
with the same name and different namespaces. 
    
    I've fixed this by making the code more like the Java, i.e. adding a Fullname method to
the base Schema class, and using this when processing the UnionSchema. 
    
    I have not checked for the same issue in other languages. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Simon24601/avro AVRO1363

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/avro/pull/131.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #131
    
----
commit a2718fed6f8e32073ae71292b49d843adb65643d
Author: Simon Woodford <simonwoodford@gmail.com>
Date:   2016-05-23T23:22:33Z

    AVRO-1849 Fix the issue where converting the schema of a record with no fields produced
an invalid JSON

commit 58ecc80a08d0df711ca89dc94ebe97de61b26e5d
Author: Simon24601 <simonwoodford@gmail.com>
Date:   2016-09-14T10:17:09Z

    Merge remote-tracking branch 'avroMain/master'

commit 700af696cea8f66aad371e1472c42972e78aefe3
Author: srw <srw@localhost>
Date:   2016-09-14T22:26:01Z

    Merge branch 'master' of https://github.com/apache/avro

commit 39c5195c4ac0d404296e88aa7beda91308405cd1
Author: srw <srw@localhost>
Date:   2016-09-22T22:38:43Z

    Fix style issues in the code.

commit 3f0ec2cf6f36f64e3775880773f6488827d2492b
Author: srw <srw@localhost>
Date:   2016-09-22T22:55:20Z

    Merge branch 'master' of https://github.com/apache/avro

commit d3d0aa84daba998f084140a0c82633babe561a50
Author: srw <srw@localhost>
Date:   2016-09-22T22:59:29Z

    Merge branch 'master' of https://github.com/Simon24601/avro

commit e80fd1aa4c9cc8b5cccbb35a33903d6988109172
Author: srw <srw@localhost>
Date:   2016-09-24T00:47:55Z

    Fix the build scripts; build.sh requires the :z addition to work on SELinux (see Jira
1925). lang/c++/build.sh refers to the lang/c++/build directory which is empty. These are
now fixed.

commit f7826c623a73c8daccdaae618f8eeb58cd601dd7
Author: srw <srw@localhost>
Date:   2016-09-24T00:54:57Z

    Update to use BOOST_TEST_CHECKPOINT

commit 3ad5aaca13a0b82b42090139b7f1369e0e65427d
Author: srw <srw@localhost>
Date:   2016-09-26T22:16:44Z

    AVRO-1926 Revert changes to the lang/c++/build.sh script and add the SchemaTests to the
list of tests. Also revert SELinux changes to build.sh as these should be committed separately

commit 800247f9a7003a2313d5ae9dad8feaf261f7ddfc
Author: srw <srw@localhost>
Date:   2016-09-26T23:11:50Z

    AVRO-1363 Fix the parsing of a union schema with duplicate names but different namespaces.
In Java, this works, but not in C#

commit e424f9fcec9632573e684bb11b231ef48695d005
Author: srw <srw@localhost>
Date:   2016-09-26T23:23:46Z

    Remove c++ changes from the AVRO1363 branch

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message