avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From radai-rosenblatt <...@git.apache.org>
Subject [GitHub] avro pull request #119: fix TestIdl to pass on windows
Date Wed, 07 Sep 2016 04:31:37 GMT
GitHub user radai-rosenblatt opened a pull request:

    https://github.com/apache/avro/pull/119

    fix TestIdl to pass on windows

    for some of the avdl input files for the test the copyright statement is picked up as
the doc string. when generating jackson escapes \n and \r characters, resulting in a doc string
that contains the 2 characters '\' followed by 'r' instead of '\r'. the test tries to strip
out \r to "normalize" \r\n into \n, but the input actually contains '\' 'r' '\' 'n', causing
the test to fail on windows.
    Signed-off-by: radai-rosenblatt <radai.rosenblatt@gmail.com>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/radai-rosenblatt/avro build-on-windows

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/avro/pull/119.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #119
    
----
commit 5a697806d18224fc0ac39999537124e542bc773f
Author: radai-rosenblatt <radai.rosenblatt@gmail.com>
Date:   2016-09-07T04:27:08Z

    fix TestIdl to pass on windows
    
    Signed-off-by: radai-rosenblatt <radai.rosenblatt@gmail.com>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message