avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ryan Blue <rb...@netflix.com.INVALID>
Subject Re: [GitHub] avro pull request #113: AVRO-1882: ConcurrentHashMap with non-string keys fa...
Date Thu, 25 Aug 2016 00:47:39 GMT
Hi Sachin,

Thanks for the reminder on these, I was reviewing them and forgot to come
back after your changes. A polite reminder is usually the best way to get
things moving again. As I recall, they just need a final review.

rb

On Wed, Aug 24, 2016 at 5:34 PM, S G <sg.online.email@gmail.com> wrote:

> Hi,
>
> Its been about a month since this PR was submitted and there has been no
> action on this.
> In total, 35 pull requests are open and pending approval/rejection/review:
> https://github.com/apache/avro/pulls
>
> Does anyone look at opened PRs regularly?
>
> Thanks
> SG
>
> On Thu, Jul 28, 2016 at 10:36 AM, S G <sg.online.email@gmail.com> wrote:
>
> >
> > Hi,
> >
> > I submitted this pull request and seems to have the approval of a
> > committer.
> > Please let me know how I can get this merged.
> >
> > Thanks
> > SG
> >
> > On Mon, Jul 25, 2016 at 2:37 PM, sachingsachin <git@git.apache.org>
> wrote:
> >
> >> GitHub user sachingsachin opened a pull request:
> >>
> >>     https://github.com/apache/avro/pull/113
> >>
> >>     AVRO-1882: ConcurrentHashMap with non-string keys fails in Java 1.8
> >>
> >>     Also updating maven-shade-plugin as per [this thread](
> >> http://search-hadoop.com/m/F2svI1oJXGf1htLgb&subj=
> >> Re+Unable+to+build+clean+checkout+of+avro+from+master)
> >>
> >> You can merge this pull request into a Git repository by running:
> >>
> >>     $ git pull https://github.com/sachingsachin/avro AVRO_1882
> >>
> >> Alternatively you can review and apply these changes as the patch at:
> >>
> >>     https://github.com/apache/avro/pull/113.patch
> >>
> >> To close this pull request, make a commit to your master/trunk branch
> >> with (at least) the following in the commit message:
> >>
> >>     This closes #113
> >>
> >> ----
> >> commit faf46e81434adfd4b37844de67c01b39ab478ba2
> >> Author: Sachin Goyal <sgoyal6@l-sb8m1heg8w-m.local>
> >> Date:   2016-07-25T21:32:46Z
> >>
> >>     AVRO-1882: ConcurrentHashMap with non-string keys fails in Java 1.8
> >>
> >> ----
> >>
> >>
> >> ---
> >> If your project is set up for it, you can reply to this email and have
> >> your
> >> reply appear on GitHub as well. If your project does not have this
> feature
> >> enabled and wishes so, or if the feature is enabled but not working,
> >> please
> >> contact infrastructure at infrastructure@apache.org or file a JIRA
> ticket
> >> with INFRA.
> >> ---
> >>
> >
> >
>



-- 
Ryan Blue
Software Engineer
Netflix

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message