Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 826B4200B4F for ; Tue, 26 Jul 2016 19:41:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8117C160A69; Tue, 26 Jul 2016 17:41:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EF3E9160A7D for ; Tue, 26 Jul 2016 19:41:21 +0200 (CEST) Received: (qmail 13728 invoked by uid 500); 26 Jul 2016 17:41:20 -0000 Mailing-List: contact dev-help@avro.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@avro.apache.org Delivered-To: mailing list dev@avro.apache.org Received: (qmail 13574 invoked by uid 99); 26 Jul 2016 17:41:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Jul 2016 17:41:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id A93C52C027F for ; Tue, 26 Jul 2016 17:41:20 +0000 (UTC) Date: Tue, 26 Jul 2016 17:41:20 +0000 (UTC) From: "Sean Busbey (JIRA)" To: dev@avro.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (AVRO-1888) Java: Single-record encoding marker bytes check is incorrect MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 26 Jul 2016 17:41:22 -0000 [ https://issues.apache.org/jira/browse/AVRO-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated AVRO-1888: ------------------------------ Priority: Blocker (was: Major) > Java: Single-record encoding marker bytes check is incorrect > ------------------------------------------------------------ > > Key: AVRO-1888 > URL: https://issues.apache.org/jira/browse/AVRO-1888 > Project: Avro > Issue Type: Bug > Components: java > Reporter: Ryan Blue > Assignee: Ryan Blue > Priority: Blocker > Fix For: 1.8.2 > > Attachments: AVRO-1888.1.patch > > > It looks like the check for correct marker bytes is incorrect. > The check should validate both marker/version bytes match what is expected, but is instead this: > {code} > if (! (BinaryMessageEncoder.V1_HEADER[0] == header[0]) > && BinaryMessageEncoder.V1_HEADER[1] == header[1]) { . . . } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)