Mailing-List: contact dev-help@avro.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@avro.apache.org
Date: Mon, 18 Jul 2016 00:24:20 +0000 (UTC)
From: "Yibing Shi (JIRA)" <jira@apache.org>
To: dev@avro.apache.org
Message-ID: <JIRA.12990225.1468799130000.54661.1468801460602@Atlassian.JIRA>
In-Reply-To: <JIRA.12990225.1468799130000@Atlassian.JIRA>
References: <JIRA.12990225.1468799130000@Atlassian.JIRA> <JIRA.12990225.1468799130140@arcas>
Subject: [jira] [Updated] (AVRO-1883) Schema validator cannot find broken
 backwards compatibility in Union type elements
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 18 Jul 2016 00:24:27 -0000


     [ https://issues.apache.org/jira/browse/AVRO-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yibing Shi updated AVRO-1883:
-----------------------------
    Attachment: AVRO-1883.1.patch

> Schema validator cannot find broken backwards compatibility in Union type elements
> ----------------------------------------------------------------------------------
>
>                 Key: AVRO-1883
>                 URL: https://issues.apache.org/jira/browse/AVRO-1883
>             Project: Avro
>          Issue Type: Bug
>    Affects Versions: 1.8.1
>            Reporter: Yibing Shi
>            Priority: Critical
>         Attachments: AVRO-1883.1.patch
>
>
> Consider below 2 schemas:
> *Schema 1*:
> {noformat}
> [
>   {
>     "type": "record",
>     "name": "rec1",
>     "fields": [
>       {
>         "name": "age",
>         "type": "long"
>       }
>     ]
>   },
>   {
>     "type": "record",
>     "name": "rec2",
>     "fields": [
>       {
>         "name": "username",
>         "type": "string"
>       }
>     ]
>   }
> ]
> {noformat}
> *Schema 2*:
> {noformat}
> [
>   {
>     "type": "record",
>     "name": "rec1",
>     "fields": [
>       {
>         "name": "age",
>         "type": "long"
>       },
>       {
>         "name": "address",
>         "type": "string"
>       }
>     ]
>   },
>   {
>     "type": "record",
>     "name": "rec2",
>     "fields": [
>       {
>         "name": "username",
>         "type": "string"
>       }
>     ]
>   }
> ]
> {noformat}
> The {{rec1}} field in these 2 unions are not compatible, because the {{address}} field of {{rec1}} in the second one is not nullable. However, if we check them with validate like below, validator doesn't return any error:
> {code}
>     final SchemaValidator backwardValidator = new SchemaValidatorBuilder().canReadStrategy().validateLatest();
>     final Schema schema1 = new Schema.Parser().parse(schema1Str);
>     final Schema schema2 = new Schema.Parser().parse(schema2Str);
>     backwardValidator.validate(schema2, Arrays.asList(schema1));
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)