Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B024B200B11 for ; Mon, 13 Jun 2016 21:28:31 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id AE974160A3C; Mon, 13 Jun 2016 19:28:31 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 29F4B160A1A for ; Mon, 13 Jun 2016 21:28:31 +0200 (CEST) Received: (qmail 84538 invoked by uid 500); 13 Jun 2016 19:28:30 -0000 Mailing-List: contact dev-help@avro.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@avro.apache.org Delivered-To: mailing list dev@avro.apache.org Received: (qmail 84521 invoked by uid 99); 13 Jun 2016 19:28:30 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Jun 2016 19:28:30 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 28BFE2C1F5D for ; Mon, 13 Jun 2016 19:28:30 +0000 (UTC) Date: Mon, 13 Jun 2016 19:28:30 +0000 (UTC) From: "Ryan Blue (JIRA)" To: dev@avro.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AVRO-1847) IDL compiler uses ByteBuffer for decimal type even if logical type is supported MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 13 Jun 2016 19:28:31 -0000 [ https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15328006#comment-15328006 ] Ryan Blue commented on AVRO-1847: --------------------------------- I think you're right. In that case, we could have a common method that throws ClassCastException and make this new one catch it and throw AvroRuntimeException. Or if that's not possible because of package layout, we could do the opposite temporarily even though that would be odd. > IDL compiler uses ByteBuffer for decimal type even if logical type is supported > -------------------------------------------------------------------------------- > > Key: AVRO-1847 > URL: https://issues.apache.org/jira/browse/AVRO-1847 > Project: Avro > Issue Type: Bug > Components: java > Affects Versions: 1.8.0 > Reporter: Yibing Shi > Assignee: Yibing Shi > Attachments: AVRO-1847.1.patch, AVRO-1847.2.patch, AVRO-1847.3.patch, AVRO-1847.4.patch > > > Version 1.8.0 has added the support of logical types. A conversion class (Conversions.DecimalConversion) has also been added for decimal type. However, the IDL compiler still uses ByteBuffer for decimal types, which is not the same behaviour as data, time or timestamp type (added in AVRO-1684). -- This message was sent by Atlassian JIRA (v6.3.4#6332)