avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1847) IDL compiler uses ByteBuffer for decimal type even if logical type is supported
Date Mon, 13 Jun 2016 17:14:20 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15327769#comment-15327769
] 

Sean Busbey commented on AVRO-1847:
-----------------------------------

{code}
diff --git a/lang/java/maven-plugin/src/main/java/org/apache/avro/mojo/AbstractAvroMojo.java
b/lang/java/maven-plugin/src/main/java/org/apache/avro/mojo/AbstractAvroMojo.java
index 83db1c0..7f7b62d 100644
--- a/lang/java/maven-plugin/src/main/java/org/apache/avro/mojo/AbstractAvroMojo.java
+++ b/lang/java/maven-plugin/src/main/java/org/apache/avro/mojo/AbstractAvroMojo.java
@@ -123,6 +123,13 @@ public abstract class AbstractAvroMojo extends AbstractMojo {
   protected boolean createSetters;
 
   /**
+   * Determines whether or not to use Java classes for decimal types
+   *
+   * @parameter default-value="false"
+   */
+  protected boolean enableLogicalTypes;
+
+  /**
{code}

This has the same compatibility concern as the change to the specific compiler itself.

> IDL compiler uses ByteBuffer for decimal type even if logical type is supported 
> --------------------------------------------------------------------------------
>
>                 Key: AVRO-1847
>                 URL: https://issues.apache.org/jira/browse/AVRO-1847
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.8.0
>            Reporter: Yibing Shi
>            Assignee: Yibing Shi
>         Attachments: AVRO-1847.1.patch, AVRO-1847.2.patch, AVRO-1847.3.patch, AVRO-1847.4.patch
>
>
> Version 1.8.0 has added the support of logical types. A conversion class (Conversions.DecimalConversion)
has also been added for decimal type. However, the IDL compiler still uses ByteBuffer for
decimal types, which is not the same behaviour as data, time or timestamp type (added in AVRO-1684).




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message