avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yibing Shi (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (AVRO-1847) IDL compiler uses ByteBuffer for decimal type even if logical type is supported
Date Fri, 17 Jun 2016 12:41:05 GMT

     [ https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Yibing Shi updated AVRO-1847:
    Attachment: AVRO-1847.7.patch

Upload a new patch:
# Fixed all the javadoc errors pointed out by [~busbey]
# Use {{IllegalArugumentException}} instead of {{AvroRuntimeException}} in {{Conversions.convert...}}
# Add javadoc to {{GenericDatumWriter/Reader.convert}} to describe the behaviour change (different
exception type is thrown out now). [~rdblue], would you please help confirm whether this is
OK for you?

And as [~busbey] said, I have added below test cases in {{TestSpecificCompiler}}:
# testJavaTypeWithDecimalLogicalTypeEnabled
# testJavaTypeWithoutDecimalLogicalTypeEnabled
to test whether the decimal logical type enablement would affect other logical types. [~rdblue],
please help confirm whether it is enough, or you want to add more tests?

> IDL compiler uses ByteBuffer for decimal type even if logical type is supported 
> --------------------------------------------------------------------------------
>                 Key: AVRO-1847
>                 URL: https://issues.apache.org/jira/browse/AVRO-1847
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.8.0
>            Reporter: Yibing Shi
>            Assignee: Yibing Shi
>         Attachments: AVRO-1847.1.patch, AVRO-1847.2.patch, AVRO-1847.3.patch, AVRO-1847.4.patch,
AVRO-1847.5.patch, AVRO-1847.6.patch, AVRO-1847.7.patch
> Version 1.8.0 has added the support of logical types. A conversion class (Conversions.DecimalConversion)
has also been added for decimal type. However, the IDL compiler still uses ByteBuffer for
decimal types, which is not the same behaviour as data, time or timestamp type (added in AVRO-1684).

This message was sent by Atlassian JIRA

View raw message