avro-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AVRO-1847) IDL compiler uses ByteBuffer for decimal type even if logical type is supported
Date Mon, 13 Jun 2016 18:47:30 GMT

    [ https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15327903#comment-15327903
] 

Sean Busbey commented on AVRO-1847:
-----------------------------------

I can see that, but then we just move the check for a non-null conversion out to where this
gets called (and then treat it as pass-through).

Any objection to just making both of them do pass-through when the conversion is null?

> IDL compiler uses ByteBuffer for decimal type even if logical type is supported 
> --------------------------------------------------------------------------------
>
>                 Key: AVRO-1847
>                 URL: https://issues.apache.org/jira/browse/AVRO-1847
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.8.0
>            Reporter: Yibing Shi
>            Assignee: Yibing Shi
>         Attachments: AVRO-1847.1.patch, AVRO-1847.2.patch, AVRO-1847.3.patch, AVRO-1847.4.patch
>
>
> Version 1.8.0 has added the support of logical types. A conversion class (Conversions.DecimalConversion)
has also been added for decimal type. However, the IDL compiler still uses ByteBuffer for
decimal types, which is not the same behaviour as data, time or timestamp type (added in AVRO-1684).




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message