Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BD03F200ACB for ; Mon, 9 May 2016 01:01:14 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id BB8E1160A14; Sun, 8 May 2016 23:01:14 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 36E31160A07 for ; Mon, 9 May 2016 01:01:14 +0200 (CEST) Received: (qmail 44776 invoked by uid 500); 8 May 2016 23:01:13 -0000 Mailing-List: contact dev-help@avro.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@avro.apache.org Delivered-To: mailing list dev@avro.apache.org Received: (qmail 44604 invoked by uid 99); 8 May 2016 23:01:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 May 2016 23:01:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D9CFE2C1F5C for ; Sun, 8 May 2016 23:01:12 +0000 (UTC) Date: Sun, 8 May 2016 23:01:12 +0000 (UTC) From: "Ryan Blue (JIRA)" To: dev@avro.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AVRO-1838) Ensure Checkstyle enforces trailing spaces rule MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sun, 08 May 2016 23:01:14 -0000 [ https://issues.apache.org/jira/browse/AVRO-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15275782#comment-15275782 ] Ryan Blue commented on AVRO-1838: --------------------------------- Sounds fine to me. Looks like it keeps the checkstyle stuff all contained, too. > Ensure Checkstyle enforces trailing spaces rule > ----------------------------------------------- > > Key: AVRO-1838 > URL: https://issues.apache.org/jira/browse/AVRO-1838 > Project: Avro > Issue Type: Improvement > Components: java > Affects Versions: 1.8.0 > Reporter: Niels Basjes > Assignee: Niels Basjes > Labels: checkstyle > Fix For: 1.8.1 > > Attachments: AVRO-1838-20160502-BuildFails.patch, AVRO-1838-20160502-disable-RedundantModifier.patch, AVRO-1838-20160504.patch > > > Followup of AVRO-1828 > We want to make sure the code stays as clean as possible by ensuring that Checkstyle fails the build if they are present. > The checkstyle maven module describes how to do this in a multi module project (like avro): > https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/multi-module-config.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)